Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhel8 support #7287

Merged
merged 3 commits into from Jul 22, 2019
Merged

Rhel8 support #7287

merged 3 commits into from Jul 22, 2019

Conversation

neoakris
Copy link

Ran some directions as per
#7130

here's what I've done
git clone git@github.com:VibrentHealth/kops.git
cd kops
git remote add upstream https://github.com/kubernetes/kops
git fetch upstream
git merge upstream/master
git push origin
//(our fork's master is now synced with upstream master)

git checkout -b rhel8_support
git cherry-pick f449e61
git cherry-pick 592d7cd
git cherry-pick 05c5af4
git diff master
//(makes it look like only the desired diff is captured)

Created this new PR
Also worth mentioning: I looked into signing the CLA, and to my knowledge, the VibrentHealth organization signed it, and since myself and Cassandra are part of that organization we're good. Let me know if I'm mistaken on that.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @neoakris. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2019
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2019
@justinsb
Copy link
Member

This looks great, thanks for rebasing @neoakris .

The switch from ntp to chrony will take place also for rhel7, which I guess is OK - typically we have tried not to change behavior on previous versions, but in this case I think we can just add it to the release notes for whatever version we first cherry-pick this back to!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, neoakris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@justinsb
Copy link
Member

(Also, I have an open PR to move that to code, so I'll likely just update that one to keep rhel7 / centos7 using the ntp package ... unless there is some reason we should actively change rhel7 / centos7?)

@k8s-ci-robot k8s-ci-robot merged commit 9290330 into kubernetes:master Jul 22, 2019
k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019
@cassandracomar cassandracomar deleted the rhel8_support branch November 19, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants