Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weave to 2.5.2 #7444

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@while1eq1
Copy link
Contributor

commented Aug 21, 2019

This PR updates weave to 2.5.2 to alleviate the following issues:

  • In Kubernetes cluster, when a pod is deleted and at the same time if weave-net pod is restarting or in rare occasion like when weave-kube container is hung then IP address assigned to the pod is not freed and never released, potentially running out of IP's to allocate to the pod's on the node #3587, #3638

  • In Kubernetes cluster a reclaim daemon runs as part of kube-utils that automates weave forget for deleted nodes. Fixes panic that occurs in reclaim daemon resulting in weave to attempt to connect to dead nodes #3613, #3623

This can be seen here - https://github.com/weaveworks/weave/releases/tag/v2.5.2

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Hi @while1eq1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikesplain

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Aug 21, 2019
@mikesplain

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Thanks @while1eq1!

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, while1eq1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikesplain

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Cherry pick opened for 1.14

@mikesplain

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

/retest

k8s-ci-robot added a commit that referenced this pull request Aug 22, 2019
…44-origin-release-1.14

Automated cherry pick of #7444: upgrade weave to 2.5.2 to address the issues in
@k8s-ci-robot k8s-ci-robot merged commit 3e88503 into kubernetes:master Aug 22, 2019
11 checks passed
11 checks passed
cla/linuxfoundation while1eq1 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kops-bazel-build Job succeeded.
Details
pull-kops-bazel-test Job succeeded.
Details
pull-kops-e2e-kubernetes-aws Job succeeded.
Details
pull-kops-verify-bazel Job succeeded.
Details
pull-kops-verify-boilerplate Job succeeded.
Details
pull-kops-verify-gofmt Job succeeded.
Details
pull-kops-verify-govet Job succeeded.
Details
pull-kops-verify-packages Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.