Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update channel recommended versions for kops versions #7446

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@justinsb
Copy link
Member

commented Aug 22, 2019

The kubernetesVersion in the kopsVersions block is used for new
clusters. I had forgotten to update it, so new clusters were being
created with versions that then immediately recommended an update.

The kubernetesVersion in the kopsVersions block is used for new
clusters.  I had forgotten to update it, so new clusters were being
created with versions that then immediately recommended an update.
@justinsb

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

(We could / should also clean up this logic, as it's probably unnecessary, and we could simply look at the matching kops => k8s version. We could also warn people if they're running a k8s version with a bigger minor version than their kops version. But that's probably a separate PR!)

@mikesplain

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Thanks @justinsb!

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 19a8da7 into kubernetes:master Aug 22, 2019
11 checks passed
11 checks passed
cla/linuxfoundation justinsb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kops-bazel-build Job succeeded.
Details
pull-kops-bazel-test Job succeeded.
Details
pull-kops-e2e-kubernetes-aws Job succeeded.
Details
pull-kops-verify-bazel Job succeeded.
Details
pull-kops-verify-boilerplate Job succeeded.
Details
pull-kops-verify-gofmt Job succeeded.
Details
pull-kops-verify-govet Job succeeded.
Details
pull-kops-verify-packages Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.