Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash script: don't assume nodeup filename #7448

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@justinsb
Copy link
Member

commented Aug 22, 2019

We were previously assuming that the name of the URL matched the name
we wanted to download to, but also assuming that the name of the file
was nodeup. Change to download to a known file location, whatever the
mirror url.

We were previously assuming that the name of the URL matched the name
we wanted to download to, but also assuming that the name of the file
was nodeup.  Change to download to a known file location, whatever the
mirror url.
@justinsb justinsb force-pushed the justinsb:nodeup_filename branch from 83b0b0f to 05bbf9c Aug 22, 2019
@mikesplain

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Thanks @justinsb!

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0a719be into kubernetes:master Aug 22, 2019
10 of 11 checks passed
10 of 11 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation justinsb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kops-bazel-build Job succeeded.
Details
pull-kops-bazel-test Job succeeded.
Details
pull-kops-e2e-kubernetes-aws Job succeeded.
Details
pull-kops-verify-bazel Job succeeded.
Details
pull-kops-verify-boilerplate Job succeeded.
Details
pull-kops-verify-gofmt Job succeeded.
Details
pull-kops-verify-govet Job succeeded.
Details
pull-kops-verify-packages Job succeeded.
Details
k8s-ci-robot added a commit that referenced this pull request Aug 22, 2019
Cherry pick of #7448 onto release-1.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.