Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updocs: fix link to Metrics Server user guide #7479
Conversation
This comment has been minimized.
This comment has been minimized.
Welcome @ruxandrafed! |
This comment has been minimized.
This comment has been minimized.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This comment has been minimized.
This comment has been minimized.
Hi @ruxandrafed. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ruxandrafed can you take a look at signing the CLA? The great new is that once you sign it it applied to all the projects under Kubernetes. |
s |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ruxandrafed
Sep 1, 2019
Author
Contributor
@rdrgmnzs Reviewed and removed the newline. The s
was already in there and it looked like a typo, so I removed it. Thank you for your patience!
This comment has been minimized.
This comment has been minimized.
Hi @rdrgmnzs, sorry for the delay. I just started a new job and would like to clarify things with the company before I sign. Will do so ASAP and will also correct the above mentioned issue. Thank you for your patience! |
d91151d
to
b56bf0c
/ok-to-test |
b56bf0c
to
0c545dd
This comment has been minimized.
This comment has been minimized.
Thanks @ruxandrafed! /lgtm |
This comment has been minimized.
This comment has been minimized.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain, ruxandrafed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6b75944
into
kubernetes:master
ruxandrafed commentedAug 27, 2019
Broken link: https://kubernetes.io/docs/tasks/debug-application-cluster/core-metrics-pipeline/
I assume the correct/updated URL is: https://kubernetes.io/docs/tasks/debug-application-cluster/resource-metrics-pipeline/
Thank you!