Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static check error in vfssync.go #7482

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@beautytiger
Copy link
Contributor

beautytiger commented Aug 28, 2019

No description provided.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Aug 28, 2019

Hi @beautytiger. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M label Aug 28, 2019
@k8s-ci-robot k8s-ci-robot requested review from robinpercy and zetaab Aug 28, 2019
@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Aug 29, 2019

Thanks @beautytiger

/approve
/lgtm
/ok-to-test

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Aug 29, 2019

/retest

@rdrgmnzs

This comment has been minimized.

Copy link
Contributor

rdrgmnzs commented Aug 29, 2019

Hi @beautytiger, this looks great. Can you follow the instructions at https://github.com/kubernetes/kops/blob/master/docs/development/api_updates.md#updating-the-generated-api-code to re-generate the API code.

Thanks!

@beautytiger beautytiger force-pushed the beautytiger:static_check_fix branch from d36a1f7 to ad752f4 Sep 1, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 1, 2019
@beautytiger

This comment has been minimized.

Copy link
Contributor Author

beautytiger commented Sep 1, 2019

@rdrgmnzs
Thanks for your instruction.
Rebased and run make apimachinery && make, it seems ok.

Copy link
Member

mikesplain left a comment

Thanks @beautytiger!

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: beautytiger, justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9e8c0b4 into kubernetes:master Sep 7, 2019
11 checks passed
11 checks passed
cla/linuxfoundation beautytiger authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kops-bazel-build Job succeeded.
Details
pull-kops-bazel-test Job succeeded.
Details
pull-kops-e2e-kubernetes-aws Job succeeded.
Details
pull-kops-verify-bazel Job succeeded.
Details
pull-kops-verify-boilerplate Job succeeded.
Details
pull-kops-verify-gofmt Job succeeded.
Details
pull-kops-verify-govet Job succeeded.
Details
pull-kops-verify-packages Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.