Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to golang v1.13.1 #7736

Open
wants to merge 1 commit into
base: master
from

Conversation

@chenrui333
Copy link
Member

commented Oct 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

Welcome @chenrui333!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenrui333
To complete the pull request process, please assign chrislovecnm
You can assign the PR to them by writing /assign @chrislovecnm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikesplain

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Hi @chenrui333 thanks so much for submitting, unfortunately kops has to keep it's versions in line with the overall Kubernetes version, which is why we specify kops 1.14 needs to be built with the same version as Kubernetes 1.14 (see https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.14.md#notable-features) which is go1.12. What's the issue with 1.12 and Catalina?

@mikesplain

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Oh we don't lock ours to 1.12, I'll amend thanks!

@chenrui333

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

Totally make sense, I will close the PR now.

@chenrui333

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

If just the brew build issue (i.e. brew install issue) with Catalina, we can still go for the merge.

Otherwise if it is the test failure, we need to fix with the Catalina build.

@chenrui333 chenrui333 closed this Oct 3, 2019
@chenrui333 chenrui333 reopened this Oct 3, 2019
@chenrui333

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

Oh we don't lock ours to 1.12, I'll amend thanks!

Sounds like we can still go with 1.13 for the build, right?

I am mostly thinking from the build perspective.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@chenrui333: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 246d709 link /test pull-kops-e2e-kubernetes-aws
pull-kops-bazel-test 246d709 link /test pull-kops-bazel-test
pull-kops-bazel-build 246d709 link /test pull-kops-bazel-build
pull-kops-verify-gofmt 246d709 link /test pull-kops-verify-gofmt
pull-kops-verify-generated 246d709 link /test pull-kops-verify-generated

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.