From f01e8e4cdddaf20935b1a3f5490ab378ed953768 Mon Sep 17 00:00:00 2001 From: tanjunchen Date: Tue, 31 Dec 2019 16:15:28 +0800 Subject: [PATCH] upup/pkg/fi/cloudup/ staticcheck --- upup/pkg/fi/cloudup/awsup/aws_cloud.go | 10 ++--- upup/pkg/fi/cloudup/awsup/aws_utils.go | 6 +-- upup/pkg/fi/cloudup/defaults.go | 2 +- upup/pkg/fi/cloudup/dns.go | 6 +-- upup/pkg/fi/cloudup/gce/gce_cloud.go | 4 +- upup/pkg/fi/cloudup/gce/labels.go | 2 +- upup/pkg/fi/cloudup/gcetasks/address.go | 2 +- upup/pkg/fi/cloudup/gcetasks/disk.go | 2 +- .../pkg/fi/cloudup/gcetasks/forwardingrule.go | 2 +- upup/pkg/fi/cloudup/gcetasks/instance.go | 2 +- upup/pkg/fi/cloudup/loader.go | 4 +- .../fi/cloudup/openstack/availability_zone.go | 6 +-- upup/pkg/fi/cloudup/openstack/cloud.go | 12 +++--- upup/pkg/fi/cloudup/openstack/floatingip.go | 12 +++--- upup/pkg/fi/cloudup/openstack/instance.go | 4 +- upup/pkg/fi/cloudup/openstack/loadbalancer.go | 40 +++++++++---------- 16 files changed, 58 insertions(+), 58 deletions(-) diff --git a/upup/pkg/fi/cloudup/awsup/aws_cloud.go b/upup/pkg/fi/cloudup/awsup/aws_cloud.go index 3400cf34058e1..490239a9fdc06 100644 --- a/upup/pkg/fi/cloudup/awsup/aws_cloud.go +++ b/upup/pkg/fi/cloudup/awsup/aws_cloud.go @@ -746,7 +746,7 @@ func getTags(c AWSCloud, resourceID string) (map[string]string, error) { if err != nil { if isTagsEventualConsistencyError(err) { if attempt > DescribeTagsMaxAttempts { - return nil, fmt.Errorf("Got retryable error while getting tags on %q, but retried too many times without success: %v", resourceID, err) + return nil, fmt.Errorf("got retryable error while getting tags on %q, but retried too many times without success: %v", resourceID, err) } if (attempt % DescribeTagsLogInterval) == 0 { @@ -801,7 +801,7 @@ func createTags(c AWSCloud, resourceID string, tags map[string]string) error { if err != nil { if isTagsEventualConsistencyError(err) { if attempt > CreateTagsMaxAttempts { - return fmt.Errorf("Got retryable error while creating tags on %q, but retried too many times without success: %v", resourceID, err) + return fmt.Errorf("got retryable error while creating tags on %q, but retried too many times without success: %v", resourceID, err) } if (attempt % CreateTagsLogInterval) == 0 { @@ -849,7 +849,7 @@ func deleteTags(c AWSCloud, resourceID string, tags map[string]string) error { if err != nil { if isTagsEventualConsistencyError(err) { if attempt > DeleteTagsMaxAttempts { - return fmt.Errorf("Got retryable error while deleting tags on %q, but retried too many times without success: %v", resourceID, err) + return fmt.Errorf("got retryable error while deleting tags on %q, but retried too many times without success: %v", resourceID, err) } if (attempt % DeleteTagsLogInterval) == 0 { @@ -1237,7 +1237,7 @@ func ValidateZones(zones []string, cloud AWSCloud) error { } klog.Infof("Known zones: %q", strings.Join(knownZones, ",")) - return fmt.Errorf("Zone is not a recognized AZ: %q (check you have specified a valid zone?)", zone) + return fmt.Errorf("error Zone is not a recognized AZ: %q (check you have specified a valid zone?)", zone) } for _, message := range z.Messages { @@ -1255,7 +1255,7 @@ func ValidateZones(zones []string, cloud AWSCloud) error { func (c *awsCloudImplementation) DNS() (dnsprovider.Interface, error) { provider, err := dnsprovider.GetDnsProvider(dnsproviderroute53.ProviderName, nil) if err != nil { - return nil, fmt.Errorf("Error building (k8s) DNS provider: %v", err) + return nil, fmt.Errorf("error building (k8s) DNS provider: %v", err) } return provider, nil } diff --git a/upup/pkg/fi/cloudup/awsup/aws_utils.go b/upup/pkg/fi/cloudup/awsup/aws_utils.go index d0f7614272ef0..d02b04c47b69c 100644 --- a/upup/pkg/fi/cloudup/awsup/aws_utils.go +++ b/upup/pkg/fi/cloudup/awsup/aws_utils.go @@ -73,14 +73,14 @@ func ValidateRegion(region string) error { sess, err := session.NewSession(config) if err != nil { - return fmt.Errorf("Error starting a new AWS session: %v", err) + return fmt.Errorf("error starting a new AWS session: %v", err) } client := ec2.New(sess, config) response, err := client.DescribeRegions(request) if err != nil { - return fmt.Errorf("Got an error while querying for valid regions (verify your AWS credentials?): %v", err) + return fmt.Errorf("got an error while querying for valid regions (verify your AWS credentials?): %v", err) } allRegions = response.Regions } @@ -114,7 +114,7 @@ func FindRegion(cluster *kops.Cluster) (string, error) { zoneRegion := subnet.Zone[:len(subnet.Zone)-1] if region != "" && zoneRegion != region { - return "", fmt.Errorf("Clusters cannot span multiple regions (found zone %q, but region is %q)", subnet.Zone, region) + return "", fmt.Errorf("error Clusters cannot span multiple regions (found zone %q, but region is %q)", subnet.Zone, region) } region = zoneRegion diff --git a/upup/pkg/fi/cloudup/defaults.go b/upup/pkg/fi/cloudup/defaults.go index e6b7072112eba..61ec2570977cc 100644 --- a/upup/pkg/fi/cloudup/defaults.go +++ b/upup/pkg/fi/cloudup/defaults.go @@ -69,7 +69,7 @@ func PerformAssignments(c *kops.Cluster) error { } c.Spec.NetworkCIDR = vpcInfo.CIDR if c.Spec.NetworkCIDR == "" { - return fmt.Errorf("Unable to infer NetworkCIDR from VPC ID, please specify --network-cidr") + return fmt.Errorf("unable to infer NetworkCIDR from VPC ID, please specify --network-cidr") } } else { if cloud.ProviderID() == kops.CloudProviderAWS { diff --git a/upup/pkg/fi/cloudup/dns.go b/upup/pkg/fi/cloudup/dns.go index 49da4fdca94ed..45e88723f22fd 100644 --- a/upup/pkg/fi/cloudup/dns.go +++ b/upup/pkg/fi/cloudup/dns.go @@ -68,7 +68,7 @@ func findZone(cluster *kops.Cluster, cloud fi.Cloud) (dnsprovider.Zone, error) { } } if len(matches) == 0 { - return nil, fmt.Errorf("cannot find DNS Zone %q. Please pre-create the zone and set up NS records so that it resolves.", cluster.Spec.DNSZone) + return nil, fmt.Errorf("cannot find DNS Zone %q. Please pre-create the zone and set up NS records so that it resolves", cluster.Spec.DNSZone) } if len(matches) > 1 { @@ -205,7 +205,7 @@ func precreateDNS(cluster *kops.Cluster, cloud fi.Cloud) error { } else { dnsRecords, err := rrs.Get(dnsHostname) if err != nil { - return fmt.Errorf("Failed to get DNS record %s with error: %v", dnsHostname, err) + return fmt.Errorf("failed to get DNS record %s with error: %v", dnsHostname, err) } for _, dnsRecord := range dnsRecords { if dnsRecord.Type() != "A" { @@ -242,7 +242,7 @@ func precreateDNS(cluster *kops.Cluster, cloud fi.Cloud) error { if len(created) != 0 { err := changeset.Apply() if err != nil { - return fmt.Errorf("Error pre-creating DNS records: %v", err) + return fmt.Errorf("error pre-creating DNS records: %v", err) } klog.V(2).Infof("Pre-created DNS names: %v", created) } diff --git a/upup/pkg/fi/cloudup/gce/gce_cloud.go b/upup/pkg/fi/cloudup/gce/gce_cloud.go index f1b2f69f3d7f0..00b1479ee2feb 100644 --- a/upup/pkg/fi/cloudup/gce/gce_cloud.go +++ b/upup/pkg/fi/cloudup/gce/gce_cloud.go @@ -225,7 +225,7 @@ func (c *gceCloudImplementation) ServiceAccount() (string, error) { func (c *gceCloudImplementation) DNS() (dnsprovider.Interface, error) { provider, err := clouddns.CreateInterface(c.project, nil) if err != nil { - return nil, fmt.Errorf("Error building (k8s) DNS provider: %v", err) + return nil, fmt.Errorf("error building (k8s) DNS provider: %v", err) } return provider, nil } @@ -295,7 +295,7 @@ func (c *gceCloudImplementation) GetApiIngressStatus(cluster *kops.Cluster) ([]k if forwardingRule != nil { if forwardingRule.IPAddress == "" { - return nil, fmt.Errorf("Found forward rule %q, but it did not have an IPAddress", name) + return nil, fmt.Errorf("found forward rule %q, but it did not have an IPAddress", name) } ingresses = append(ingresses, kops.ApiIngressStatus{ diff --git a/upup/pkg/fi/cloudup/gce/labels.go b/upup/pkg/fi/cloudup/gce/labels.go index 2881df0bb9554..767805eb2d146 100644 --- a/upup/pkg/fi/cloudup/gce/labels.go +++ b/upup/pkg/fi/cloudup/gce/labels.go @@ -55,7 +55,7 @@ func DecodeGCELabel(s string) (string, error) { uriForm := strings.Replace(s, "-", "%", -1) v, err := url.QueryUnescape(uriForm) if err != nil { - return "", fmt.Errorf("Cannot decode GCE label: %q", s) + return "", fmt.Errorf("cannot decode GCE label: %q", s) } return v, nil } diff --git a/upup/pkg/fi/cloudup/gcetasks/address.go b/upup/pkg/fi/cloudup/gcetasks/address.go index b19cbd939a758..62e1053b352ec 100644 --- a/upup/pkg/fi/cloudup/gcetasks/address.go +++ b/upup/pkg/fi/cloudup/gcetasks/address.go @@ -131,7 +131,7 @@ func (_ *Address) RenderGCE(t *gce.GCEAPITarget, a, e, changes *Address) error { return fmt.Errorf("error waiting for IP Address: %v", err) } } else { - return fmt.Errorf("Cannot apply changes to IP Address: %v", changes) + return fmt.Errorf("cannot apply changes to IP Address: %v", changes) } return nil diff --git a/upup/pkg/fi/cloudup/gcetasks/disk.go b/upup/pkg/fi/cloudup/gcetasks/disk.go index 01019891d54c8..48d61fe51fd01 100644 --- a/upup/pkg/fi/cloudup/gcetasks/disk.go +++ b/upup/pkg/fi/cloudup/gcetasks/disk.go @@ -157,7 +157,7 @@ func (_ *Disk) RenderGCE(t *gce.GCEAPITarget, a, e, changes *Disk) error { if a != nil && changes != nil { empty := &Disk{} if !reflect.DeepEqual(empty, changes) { - return fmt.Errorf("Cannot apply changes to Disk: %v", changes) + return fmt.Errorf("cannot apply changes to Disk: %v", changes) } } diff --git a/upup/pkg/fi/cloudup/gcetasks/forwardingrule.go b/upup/pkg/fi/cloudup/gcetasks/forwardingrule.go index e0274ed45f5bb..d7e0c3f86b35f 100644 --- a/upup/pkg/fi/cloudup/gcetasks/forwardingrule.go +++ b/upup/pkg/fi/cloudup/gcetasks/forwardingrule.go @@ -131,7 +131,7 @@ func (_ *ForwardingRule) RenderGCE(t *gce.GCEAPITarget, a, e, changes *Forwardin } } else { - return fmt.Errorf("Cannot apply changes to ForwardingRule: %v", changes) + return fmt.Errorf("cannot apply changes to ForwardingRule: %v", changes) } return nil diff --git a/upup/pkg/fi/cloudup/gcetasks/instance.go b/upup/pkg/fi/cloudup/gcetasks/instance.go index 623db940780dd..a3e76878f53f2 100644 --- a/upup/pkg/fi/cloudup/gcetasks/instance.go +++ b/upup/pkg/fi/cloudup/gcetasks/instance.go @@ -348,7 +348,7 @@ func (_ *Instance) RenderGCE(t *gce.GCEAPITarget, a, e, changes *Instance) error if !changes.isZero() { klog.Errorf("Cannot apply changes to Instance: %v", changes) - return fmt.Errorf("Cannot apply changes to Instance: %v", changes) + return fmt.Errorf("cannot apply changes to Instance: %v", changes) } } diff --git a/upup/pkg/fi/cloudup/loader.go b/upup/pkg/fi/cloudup/loader.go index 08aa3a6c03603..77e5328eeecd8 100644 --- a/upup/pkg/fi/cloudup/loader.go +++ b/upup/pkg/fi/cloudup/loader.go @@ -294,7 +294,7 @@ func (l *Loader) processDeferrals() error { klog.Infof(" %s", k) } - return fmt.Errorf("Unable to find task %q, referenced from %s:%s", typeNameForTask+"/"+*name, taskKey, path) + return fmt.Errorf("unable to find task %q, referenced from %s:%s", typeNameForTask+"/"+*name, taskKey, path) } klog.V(11).Infof("Replacing task %q at %s:%s", *name, taskKey, path) @@ -317,7 +317,7 @@ func (l *Loader) processDeferrals() error { for k := range l.Resources { klog.Infof(" %s", k) } - return fmt.Errorf("Unable to find resource %q, referenced from %s:%s", rh.Name, taskKey, path) + return fmt.Errorf("unable to find resource %q, referenced from %s:%s", rh.Name, taskKey, path) } err := l.populateResource(rh, resource, args) diff --git a/upup/pkg/fi/cloudup/openstack/availability_zone.go b/upup/pkg/fi/cloudup/openstack/availability_zone.go index cadccef0230de..66ae60e104554 100644 --- a/upup/pkg/fi/cloudup/openstack/availability_zone.go +++ b/upup/pkg/fi/cloudup/openstack/availability_zone.go @@ -31,11 +31,11 @@ func (c *openstackCloud) ListAvailabilityZones(serviceClient *gophercloud.Servic azPage, err := az.List(serviceClient).AllPages() if err != nil { - return false, fmt.Errorf("Failed to list storage availability zones: %v", err) + return false, fmt.Errorf("failed to list storage availability zones: %v", err) } azList, err = az.ExtractAvailabilityZones(azPage) if err != nil { - return false, fmt.Errorf("Failed to extract storage availability zones: %v", err) + return false, fmt.Errorf("failed to extract storage availability zones: %v", err) } return true, nil }) @@ -65,5 +65,5 @@ func (c *openstackCloud) GetStorageAZFromCompute(computeAZ string) (*az.Availabi if len(azList) == 1 { return &azList[0], nil } - return nil, fmt.Errorf("No decernable storage availability zone could be mapped to compute availability zone %s", computeAZ) + return nil, fmt.Errorf("no decernable storage availability zone could be mapped to compute availability zone %s", computeAZ) } diff --git a/upup/pkg/fi/cloudup/openstack/cloud.go b/upup/pkg/fi/cloudup/openstack/cloud.go index 18edddbc9e3bb..405a7ea1d9b25 100644 --- a/upup/pkg/fi/cloudup/openstack/cloud.go +++ b/upup/pkg/fi/cloudup/openstack/cloud.go @@ -434,7 +434,7 @@ func NewOpenstackCloud(tags map[string]string, spec *kops.ClusterSpec) (Openstac Name: fi.StringValue(spec.CloudConfig.Openstack.Loadbalancer.FloatingNetwork), }) if err != nil || len(lbNet) != 1 { - return c, fmt.Errorf("could not establish floating network id.") + return c, fmt.Errorf("could not establish floating network id") } spec.CloudConfig.Openstack.Loadbalancer.FloatingNetworkID = fi.String(lbNet[0].ID) } @@ -515,7 +515,7 @@ func (c *openstackCloud) ProviderID() kops.CloudProviderID { func (c *openstackCloud) DNS() (dnsprovider.Interface, error) { provider, err := dnsprovider.GetDnsProvider(designate.ProviderName, nil) if err != nil { - return nil, fmt.Errorf("Error building (Designate) DNS provider: %v", err) + return nil, fmt.Errorf("error building (Designate) DNS provider: %v", err) } return provider, nil } @@ -526,7 +526,7 @@ func (c *openstackCloud) FindVPCInfo(id string) (*fi.VPCInfo, error) { // Find subnets in the network { if len(c.zones) == 0 { - return nil, fmt.Errorf("Could not initialize zones") + return nil, fmt.Errorf("could not initialize zones") } klog.V(2).Infof("Calling ListSubnets for subnets in Network %q", id) opt := subnets.ListOpts{ @@ -557,7 +557,7 @@ func (c *openstackCloud) DeleteGroup(g *cloudinstances.CloudInstanceGroup) error for _, id := range grp.Members { err := c.DeleteInstanceWithID(id) if err != nil { - return fmt.Errorf("Could not delete instance %q: %v", id, err) + return fmt.Errorf("could not delete instance %q: %v", id, err) } } @@ -570,14 +570,14 @@ func (c *openstackCloud) DeleteGroup(g *cloudinstances.CloudInstanceGroup) error if strings.Contains(port.Name, grp.Name) { err := c.DeletePort(port.ID) if err != nil { - return fmt.Errorf("Could not delete port %q: %v", port.ID, err) + return fmt.Errorf("could not delete port %q: %v", port.ID, err) } } } err = c.DeleteServerGroup(grp.ID) if err != nil { - return fmt.Errorf("Could not server group %q: %v", grp.ID, err) + return fmt.Errorf("could not server group %q: %v", grp.ID, err) } return nil diff --git a/upup/pkg/fi/cloudup/openstack/floatingip.go b/upup/pkg/fi/cloudup/openstack/floatingip.go index 71d47991c31d8..791560c253b63 100644 --- a/upup/pkg/fi/cloudup/openstack/floatingip.go +++ b/upup/pkg/fi/cloudup/openstack/floatingip.go @@ -99,11 +99,11 @@ func (c *openstackCloud) ListFloatingIPs() (fips []floatingips.FloatingIP, err e done, err := vfs.RetryWithBackoff(readBackoff, func() (bool, error) { pages, err := floatingips.List(c.ComputeClient()).AllPages() if err != nil { - return false, fmt.Errorf("Failed to list floating ip: %v", err) + return false, fmt.Errorf("failed to list floating ip: %v", err) } fips, err = floatingips.ExtractFloatingIPs(pages) if err != nil { - return false, fmt.Errorf("Failed to extract floating ip: %v", err) + return false, fmt.Errorf("failed to extract floating ip: %v", err) } return true, nil }) @@ -121,11 +121,11 @@ func (c *openstackCloud) ListL3FloatingIPs(opts l3floatingip.ListOpts) (fips []l done, err := vfs.RetryWithBackoff(readBackoff, func() (bool, error) { page, err := l3floatingip.List(c.NetworkingClient(), opts).AllPages() if err != nil { - return false, fmt.Errorf("Failed to list L3 floating ip: %v", err) + return false, fmt.Errorf("failed to list L3 floating ip: %v", err) } fips, err = l3floatingip.ExtractFloatingIPs(page) if err != nil { - return false, fmt.Errorf("Failed to extract L3 floating ip: %v", err) + return false, fmt.Errorf("failed to extract L3 floating ip: %v", err) } return true, nil }) @@ -143,7 +143,7 @@ func (c *openstackCloud) DeleteFloatingIP(id string) (err error) { done, err := vfs.RetryWithBackoff(writeBackoff, func() (bool, error) { err = l3floatingip.Delete(c.ComputeClient(), id).ExtractErr() if err != nil && !isNotFound(err) { - return false, fmt.Errorf("Failed to delete floating ip %s: %v", id, err) + return false, fmt.Errorf("failed to delete floating ip %s: %v", id, err) } return true, nil }) @@ -158,7 +158,7 @@ func (c *openstackCloud) DeleteL3FloatingIP(id string) (err error) { done, err := vfs.RetryWithBackoff(writeBackoff, func() (bool, error) { err = l3floatingip.Delete(c.NetworkingClient(), id).ExtractErr() if err != nil && !isNotFound(err) { - return false, fmt.Errorf("Failed to delete L3 floating ip %s: %v", id, err) + return false, fmt.Errorf("failed to delete L3 floating ip %s: %v", id, err) } return true, nil }) diff --git a/upup/pkg/fi/cloudup/openstack/instance.go b/upup/pkg/fi/cloudup/openstack/instance.go index 326b8cf8db2e2..8171c76fafdec 100644 --- a/upup/pkg/fi/cloudup/openstack/instance.go +++ b/upup/pkg/fi/cloudup/openstack/instance.go @@ -70,7 +70,7 @@ func (c *openstackCloud) ListServerFloatingIPs(instanceID string) ([]*string, er _, err := vfs.RetryWithBackoff(floatingBackoff, func() (bool, error) { server, err := c.GetInstance(instanceID) if err != nil { - return true, fmt.Errorf("Failed to find server with id (\"%s\"): %v", instanceID, err) + return true, fmt.Errorf("failed to find server with id (\"%s\"): %v", instanceID, err) } var addresses map[string][]Address @@ -96,7 +96,7 @@ func (c *openstackCloud) ListServerFloatingIPs(instanceID string) ([]*string, er return false, nil }) if len(result) == 0 || err != nil { - return result, fmt.Errorf("Could not find floating ip associated to server (\"%s\") %v", instanceID, err) + return result, fmt.Errorf("could not find floating ip associated to server (\"%s\") %v", instanceID, err) } return result, nil } diff --git a/upup/pkg/fi/cloudup/openstack/loadbalancer.go b/upup/pkg/fi/cloudup/openstack/loadbalancer.go index 91dfce638cbf2..2e2e2c7bda06b 100644 --- a/upup/pkg/fi/cloudup/openstack/loadbalancer.go +++ b/upup/pkg/fi/cloudup/openstack/loadbalancer.go @@ -30,7 +30,7 @@ import ( func (c *openstackCloud) ListMonitors(opts monitors.ListOpts) (monitorList []monitors.Monitor, err error) { if c.LoadBalancerClient() == nil { - return monitorList, fmt.Errorf("Loadbalancer support not available in this deployment") + return monitorList, fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(readBackoff, func() (bool, error) { allPages, err := monitors.List(c.LoadBalancerClient(), opts).AllPages() @@ -54,7 +54,7 @@ func (c *openstackCloud) ListMonitors(opts monitors.ListOpts) (monitorList []mon func (c *openstackCloud) DeleteMonitor(monitorID string) error { if c.LoadBalancerClient() == nil { - return fmt.Errorf("Loadbalancer support not available in this deployment") + return fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(writeBackoff, func() (bool, error) { err := monitors.Delete(c.LoadBalancerClient(), monitorID).ExtractErr() @@ -74,7 +74,7 @@ func (c *openstackCloud) DeleteMonitor(monitorID string) error { func (c *openstackCloud) DeletePool(poolID string) error { if c.LoadBalancerClient() == nil { - return fmt.Errorf("Loadbalancer support not available in this deployment") + return fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(writeBackoff, func() (bool, error) { @@ -95,7 +95,7 @@ func (c *openstackCloud) DeletePool(poolID string) error { func (c *openstackCloud) DeleteListener(listenerID string) error { if c.LoadBalancerClient() == nil { - return fmt.Errorf("Loadbalancer support not available in this deployment") + return fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(writeBackoff, func() (bool, error) { @@ -116,7 +116,7 @@ func (c *openstackCloud) DeleteListener(listenerID string) error { func (c *openstackCloud) DeleteLB(lbID string, opts loadbalancers.DeleteOpts) error { if c.LoadBalancerClient() == nil { - return fmt.Errorf("Loadbalancer support not available in this deployment") + return fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(writeBackoff, func() (bool, error) { @@ -137,7 +137,7 @@ func (c *openstackCloud) DeleteLB(lbID string, opts loadbalancers.DeleteOpts) er func (c *openstackCloud) CreateLB(opt loadbalancers.CreateOptsBuilder) (*loadbalancers.LoadBalancer, error) { if c.LoadBalancerClient() == nil { - return nil, fmt.Errorf("Loadbalancer support not available in this deployment") + return nil, fmt.Errorf("loadbalancer support not available in this deployment") } var i *loadbalancers.LoadBalancer @@ -160,7 +160,7 @@ func (c *openstackCloud) CreateLB(opt loadbalancers.CreateOptsBuilder) (*loadbal func (c *openstackCloud) GetLB(loadbalancerID string) (lb *loadbalancers.LoadBalancer, err error) { if c.LoadBalancerClient() == nil { - return nil, fmt.Errorf("Loadbalancer support not available in this deployment") + return nil, fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(readBackoff, func() (bool, error) { @@ -208,7 +208,7 @@ func (c *openstackCloud) ListLBs(opt loadbalancers.ListOptsBuilder) (lbs []loadb func (c *openstackCloud) GetPool(poolID string, memberID string) (member *v2pools.Member, err error) { if c.LoadBalancerClient() == nil { - return nil, fmt.Errorf("Loadbalancer support not available in this deployment") + return nil, fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(readBackoff, func() (bool, error) { @@ -229,7 +229,7 @@ func (c *openstackCloud) GetPool(poolID string, memberID string) (member *v2pool func (c *openstackCloud) AssociateToPool(server *servers.Server, poolID string, opts v2pools.CreateMemberOpts) (association *v2pools.Member, err error) { if c.LoadBalancerClient() == nil { - return nil, fmt.Errorf("Loadbalancer support not available in this deployment") + return nil, fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(writeBackoff, func() (bool, error) { @@ -238,7 +238,7 @@ func (c *openstackCloud) AssociateToPool(server *servers.Server, poolID string, // Pool association does not exist. Create it association, err = v2pools.CreateMember(c.LoadBalancerClient(), poolID, opts).Extract() if err != nil { - return false, fmt.Errorf("Failed to create pool association: %v", err) + return false, fmt.Errorf("failed to create pool association: %v", err) } return true, nil } @@ -256,13 +256,13 @@ func (c *openstackCloud) AssociateToPool(server *servers.Server, poolID string, func (c *openstackCloud) CreatePool(opts v2pools.CreateOpts) (pool *v2pools.Pool, err error) { if c.LoadBalancerClient() == nil { - return nil, fmt.Errorf("Loadbalancer support not available in this deployment") + return nil, fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(writeBackoff, func() (bool, error) { pool, err = v2pools.Create(c.LoadBalancerClient(), opts).Extract() if err != nil { - return false, fmt.Errorf("Failed to create pool: %v", err) + return false, fmt.Errorf("failed to create pool: %v", err) } return true, nil }) @@ -277,17 +277,17 @@ func (c *openstackCloud) CreatePool(opts v2pools.CreateOpts) (pool *v2pools.Pool func (c *openstackCloud) ListPools(opts v2pools.ListOpts) (poolList []v2pools.Pool, err error) { if c.LoadBalancerClient() == nil { - return poolList, fmt.Errorf("Loadbalancer support not available in this deployment") + return poolList, fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(readBackoff, func() (bool, error) { poolPage, err := v2pools.List(c.LoadBalancerClient(), opts).AllPages() if err != nil { - return false, fmt.Errorf("Failed to list pools: %v", err) + return false, fmt.Errorf("failed to list pools: %v", err) } poolList, err = v2pools.ExtractPools(poolPage) if err != nil { - return false, fmt.Errorf("Failed to extract pools: %v", err) + return false, fmt.Errorf("failed to extract pools: %v", err) } return true, nil }) @@ -302,17 +302,17 @@ func (c *openstackCloud) ListPools(opts v2pools.ListOpts) (poolList []v2pools.Po func (c *openstackCloud) ListListeners(opts listeners.ListOpts) (listenerList []listeners.Listener, err error) { if c.LoadBalancerClient() == nil { - return listenerList, fmt.Errorf("Loadbalancer support not available in this deployment") + return listenerList, fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(readBackoff, func() (bool, error) { listenerPage, err := listeners.List(c.LoadBalancerClient(), opts).AllPages() if err != nil { - return false, fmt.Errorf("Failed to list listeners: %v", err) + return false, fmt.Errorf("failed to list listeners: %v", err) } listenerList, err = listeners.ExtractListeners(listenerPage) if err != nil { - return false, fmt.Errorf("Failed to extract listeners: %v", err) + return false, fmt.Errorf("failed to extract listeners: %v", err) } return true, nil }) @@ -327,13 +327,13 @@ func (c *openstackCloud) ListListeners(opts listeners.ListOpts) (listenerList [] func (c *openstackCloud) CreateListener(opts listeners.CreateOpts) (listener *listeners.Listener, err error) { if c.LoadBalancerClient() == nil { - return nil, fmt.Errorf("Loadbalancer support not available in this deployment") + return nil, fmt.Errorf("loadbalancer support not available in this deployment") } done, err := vfs.RetryWithBackoff(readBackoff, func() (bool, error) { listener, err = listeners.Create(c.LoadBalancerClient(), opts).Extract() if err != nil { - return false, fmt.Errorf("Unabled to create listener: %v", err) + return false, fmt.Errorf("unabled to create listener: %v", err) } return true, nil })