Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore already-deleted nodes during rolling update #8994

Merged
merged 1 commit into from Apr 27, 2020

Conversation

johngmyers
Copy link
Member

Fixes #8867

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot added area/rolling-update size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2020
@hakman
Copy link
Member

hakman commented Apr 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2020
@hakman
Copy link
Member

hakman commented Apr 27, 2020

/retest

Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into this recently. Thanks @johngmyers!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit d774d41 into kubernetes:master Apr 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 27, 2020
@johngmyers johngmyers deleted the ignore-deleted branch April 27, 2020 15:49
michalschott added a commit to michalschott/kops that referenced this pull request May 7, 2020
michalschott added a commit to michalschott/kops that referenced this pull request May 7, 2020
k8s-ci-robot added a commit that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KOPS 1.16 - Rolling Update Failes if Node Scales Out
4 participants