Validate IG RootVolumeType #9265
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
I wonder if this build off of #8856 to validate that the field matches the |
|
It is a thought, but compared to instance types and such, EBS types are more manageable. They have proven to not change too often. |
|
thats true 👍 |
| @@ -65,6 +65,10 @@ func ValidateInstanceGroup(g *kops.InstanceGroup) field.ErrorList { | |||
| allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "rootVolumeIops"), g.Spec.RootVolumeIops, "RootVolumeIops must be greater than 0")) | |||
| } | |||
|
|
|||
| if g.Spec.RootVolumeType != nil { | |||
There was a problem hiding this comment.
do we know if this field is only used by AWS? if there are other cloud providers with different allowed values, we might want to only perform this validation if this is an AWS IG.
There was a problem hiding this comment.
+1 a quick search shows that aliclound and gcp both use the field.
There was a problem hiding this comment.
Good catch. Ali also uses this as well.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Fixes #5807