Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example for Resources Reservation #9708

Merged
merged 2 commits into from Aug 8, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 8, 2020

Making the example for Resources Reservation closer to what should be in reality, based on the example from Kubernetes docs.
Also removing some outdated Calico scripts.

Fixes: #9692

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2020
@hakman
Copy link
Member Author

hakman commented Aug 8, 2020

/retest

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7070c3c into kubernetes:master Aug 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 8, 2020
@hakman hakman deleted the resource-reservation-docs branch August 13, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow node registration (~20 minutes) with the sympton that protokube image cannot be downloaded
3 participants