New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve imagebuilder setup and documentation #289

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@itskingori
Copy link
Member

itskingori commented Jul 29, 2017

Main objective is to remove the script in hack/setup-aws.sh and replace it using a Terraform plan (motivation explain in commit fe6e487).

I've also updated the Makefile to make the new process more logical and seemingly simpler. Evidence is in the resulting README (which I also edited to improve the flow of how one gets from A to B).

itskingori added some commits Jul 29, 2017

Replace aws setup script with terraform plan
Because it:

1. Adds ability to view changes will be applied before running.
2. Adds ability to quickly teardown what was created (and even view
   teardown plan before).
Move advanced options higher up in the guide
We should let users set this options before they type any commands. I,
for one, ended up publishing an image publicly because I hadn't seen
these options (I wouldn't preferred to, just didn't know the option
was available).

This way a user gets to skim through what's possible before they get to
the guide.
@k8s-reviewable

This comment has been minimized.

Copy link

k8s-reviewable commented Jul 29, 2017

This change is Reviewable

@itskingori

This comment has been minimized.

Copy link
Member

itskingori commented Jul 29, 2017

@cordoval

This comment has been minimized.

Copy link

cordoval commented Aug 10, 2017

👍 lgtm

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 19, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 18, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@chrislovecnm

This comment has been minimized.

Copy link
Member

chrislovecnm commented Feb 18, 2018

/lifecycle frozen
/remove-lifecycle rotten

@chrislovecnm

This comment has been minimized.

Copy link
Member

chrislovecnm commented Feb 18, 2018

@justinsb can we get a review?

@itskingori

This comment has been minimized.

Copy link
Member

itskingori commented Feb 19, 2018

@justinsb To be fair, this PR is fairly opinionated. It introduces Terraform (which might not be familiar to some people).

@itskingori itskingori closed this Dec 31, 2018

@itskingori itskingori deleted the itskingori:improve_imagebuilder_setup branch Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment