Items fields in List types do not need annotations

[lavalamp]

https://github.com/kubernetes/kube-openapi/blob/master/pkg/generators/rules/idl_tag.go#L25

This code needs to make an exception for List types (served as a result of a LIST verb and never a target for a mutating operation).

If:

• There's a Metadata v1meta.ListMeta sibling field AND
• The field is named "Items" and is a list of something

Then we should actually require that people NOT include a listType= annotation. (and ideally, suppress emitting the tag in the resulting openapi spec)

Why? Otherwise people have to add an exception for this, and I don't want people doing that for nothingburgers, it's bad karma.

[apelisse]

/wg apply

[apelisse]

/cc @mariantalla

[mariantalla]

/assign

[mariantalla]

Closing this, let's reopen if needed.

/close

[k8s-ci-robot]

@mariantalla: Closing this issue.

In response to this:

Closing this, let's reopen if needed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lavalamp]

Do we need to bump the version in k/k to start giving people the new error messages?

…

On Tue, Feb 4, 2020 at 9:47 AM Kubernetes Prow Robot < ***@***.***> wrote: @mariantalla <https://github.com/mariantalla>: Closing this issue. In response to this <#185 (comment)> : Closing this, let's reopen if needed. /close Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#185?email_source=notifications&email_token=AAE6BFVJJSCRXQEGH3WEVOTRBGS4TA5CNFSM4KNMOXA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKYRU6Q#issuecomment-582031994>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE6BFUDW3A3WO44S3E7KYDRBGS4TANCNFSM4KNMOXAQ> .

[apelisse]

Yeah, I suspect that's also going to force us to remove a lot of the "exceptions", which is always good.

[apelisse]

@mariantalla Do you want to take care of it? (not today ;-)