Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod init container metrics #762

Merged
merged 1 commit into from May 28, 2019
Merged

Conversation

tariq1890
Copy link
Member

@tariq1890 tariq1890 commented May 17, 2019

This should finish the work started by #541. Fixes #502

@thedebugger I've added you as co-author to this PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes size/L labels May 17, 2019
@k8s-ci-robot k8s-ci-robot requested review from mxinden and zouyee May 17, 2019
@tariq1890 tariq1890 force-pushed the init_container branch 3 times, most recently from 141193f to 4f012bb Compare May 17, 2019
@k8s-ci-robot k8s-ci-robot added needs-rebase and removed needs-rebase labels May 19, 2019
Co-Authored-By: Tariq Ibrahim <tariq181290@gmail.com>
Co-Authored-By: Sumit Vij <sumitvij11+github@gmail.com>
@tariq1890
Copy link
Member Author

@tariq1890 tariq1890 commented May 20, 2019

@brancz @andyxning PTAL

zouyee
zouyee approved these changes May 22, 2019
@brancz
Copy link
Member

@brancz brancz commented May 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 28, 2019
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented May 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label May 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit b01b72c into kubernetes:master May 28, 2019
2 of 3 checks passed
@tariq1890 tariq1890 deleted the init_container branch Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants