-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Evicted to reasons terminated #968
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @rmartinez3! |
Could you sign the CLA? We unfortunately cannot accept your contributions without it. |
/check-cla |
@rmartinez3 Would you be able to sign the CLA? Let us know if you face any issues :). |
adding evict reason to pod_test adding to main_test evicted reason metrics
I signed it . Re pushed to see if it picks it up. However was testing and I believe when pods get terminated and re created with different pod name. The metric will be removed. So this will work only for statefulsets. Or pod names that don't change. |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmartinez3, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your contribution @rmartinez3! |
the evicted pod state not containt container in k8s 1.14, so not any kube_pod_container_status_terminated_reason、kube_pod_container_* metrics. The pod only one container
|
What this PR does / why we need it:
Currently metric *_container_status_terminated_reason does not take in account of evicted reason. This addition takes in account of that reason