Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a way to avoid printing bootstrap token #160

Closed
errordeveloper opened this issue Feb 10, 2017 · 1 comment
Closed

There should be a way to avoid printing bootstrap token #160

errordeveloper opened this issue Feb 10, 2017 · 1 comment

Comments

@errordeveloper
Copy link
Member

When kubeadm init is used in an automated context, it still prints the token to standard out. When standard output ends up in a log file, it can be cosidered that token is leaked there and can be compromised. We could simply avoid this by either detecting a non-interactive terminal and thereby not printing the join command to the standard output, or have a flag to explicitly disable this behaviour.

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Apr 25, 2017
Automatic merge from submit-queue (batch tested with PRs 44601, 44842, 44893, 44491, 44588)

kubeadm: add flag to skip token print out

**What this PR does / why we need it**: When kubeadm init is used in an automated context, it still prints the token to standard out. When standard output ends up in a log file, it can be considered that the token is leaked there and can be compromised. This PR adds a flag you can select to not have it print out and explicitly disable this behavior.

This is a continuation from #42823 since it had to be closed.

**Which issue this PR fixes** : fixes #kubernetes/kubeadm#160

**Special notes for your reviewer**: /cc @luxas @errordeveloper 

**Release note**:
```release-note
NONE
```
@luxas
Copy link
Member

luxas commented May 29, 2017

Fixed with kubernetes/kubernetes#44588

@luxas luxas closed this as completed May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants