Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZFS isn't supported #930

Closed
kvaps opened this Issue Jun 16, 2018 · 3 comments

Comments

@kvaps
Copy link

commented Jun 16, 2018

FEATURE REQUEST

ZFS driver isn't allowed for now. This request for enable zfs support in kubeadm.

Versions

kubeadm version (use kubeadm version):

Environment:

  • Kubernetes version: &version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.4", GitCommit:"5ca598b4ba5abb89bb773071ce452e33fb66339d", GitTreeState:"clean", BuildDate:"2018-06-06T08:00:59Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
  • Cloud provider or hardware configuration: hardware
  • OS: Ubuntu 16.04.4 LTS (Xenial Xerus)
  • Kernel: 4.15.17-3-pve
  • Others:

What happened?

When you run kubeadm join, it is falling down with the next preflight check:

[preflight] Some fatal errors occurred:
        [ERROR SystemVerification]: unsupported graph driver: zfs

What you expected to happen?

Succesful join to the cluster

How to reproduce it (as minimally and precisely as possible)?

Use zfs and docker with --storage-driver zfs

Anything else we need to know?

Temprorary solution for run kubeadm with --ignore-preflight-errors=SystemVerification flag.

@neolit123

This comment has been minimized.

Copy link
Member

commented Jun 18, 2018

@kubernetes/sig-cluster-lifecycle-bugs
@kubernetes/sig-node-proposals

google says that people are actually running zfs +docker + k8s, so i'm going to assume that it just works.

but we don't treat zfs as valid here:
https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/system/docker_validator.go#L92

should i just add zfs to the GraphDriver slice?
https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/system/types_unix.go

@kvaps

This comment has been minimized.

Copy link
Author

commented Jun 18, 2018

For me zfs is working fine in test instances. We going to use it in production.

@timothysc timothysc added this to the v1.12 milestone Jun 18, 2018

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Jul 2, 2018

Kubernetes Submit Queue
Merge pull request #65635 from neolit123/zfs-fix
Automatic merge from submit-queue (batch tested with PRs 65348, 65599, 65635, 65688, 65691). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

test/e2e_node/system/types_unix: support ZFS

**What this PR does / why we need it**:

Docker validation tests in the case of ZFS used as the graph driver
fail due to "zfs" not being present in the default Docker specification.

Add "zfs" in the GraphDriver slice.

kubeadm relies on the `DockerValidator` and pre-flight checks would fail if the user is using ZFS.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Updates kubernetes/kubeadm#930

**Special notes for your reviewer**:
NONE

/cc @kubernetes/sig-node-pr-reviews 
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews 
/cc @kvaps (reported by)
/area node-e2e
/area kubeadm

**Release note**:

```release-note
Unix: support ZFS as a valid graph driver for Docker
```
@dims

This comment has been minimized.

Copy link
Member

commented Jul 7, 2018

looks like this was fixed in kubernetes/kubernetes#65635

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.