Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in kinder related to 'docker cp' #1894

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@neolit123
Copy link
Member

neolit123 commented Nov 7, 2019

commits:

kinder: fix a bug when coping files from or to a container 
kinder: handle errors from Node#CopyTo() and Node#CopyFrom()
kinder: fix typo in manager/manage.go

https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-kustomize-master

neolit123 added 3 commits Nov 7, 2019
Flip the "source" and "dest" arguments for Node#CopyTo()
and Node#CopyFrom().

xref aaf5b28
@neolit123 neolit123 force-pushed the neolit123:1.17-fix-kinder-cp-bug branch from 1fa5cae to 6c8f5b8 Nov 7, 2019
Copy link
Member

fabriziopandini left a comment

/approve
/lgtm
thanks, @neolit123 for stepping in and fixing this!

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 8, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2eed1db into kubernetes:master Nov 8, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation neolit123 authorized
Details
pull-kubeadm-kinder-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.