Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinder: add a presubmit CI workflow #1904

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@neolit123
Copy link
Member

neolit123 commented Nov 10, 2019

It performs an upgrade from ci/latest to ci/latest.

The e2e and e2e-kubeadm tasks are in dry-run mode, because
the goal of this test is to check for kinder errors and not
kubeadm / k8s errors.

test infra PR: kubernetes/test-infra#15217

Copy link
Member

fabriziopandini left a comment

@neolit123 thanks, a pre-submit job is a nice addition!
However, as soon as the release is cut, we should consider if/how to split periodic jobs and pre-submit jobs into two separated folders because the number of files under workflow is starting to get relevant

Only one minor comment from my side

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Nov 11, 2019

However, as soon as the release is cut, we should consider if/how to split periodic jobs and pre-submit jobs into two separated folders because the number of files under workflow is starting to get relevant

SGTM

@neolit123 neolit123 force-pushed the neolit123:1.17-add-kinder-presubmit branch 2 times, most recently from 74c7225 to 1f4addc Nov 11, 2019
It performs an upgrade from ci/latest to ci/latest.

The e2e and e2e-kubeadm tasks are in dry-run mode, because
the goal of this test is to check for kinder errors and not
kubeadm / k8s errors.
@neolit123 neolit123 force-pushed the neolit123:1.17-add-kinder-presubmit branch from 1f4addc to a3cefcf Nov 11, 2019
@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Nov 11, 2019

updated.

@fabriziopandini

This comment has been minimized.

Copy link
Member

fabriziopandini commented Nov 12, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 12, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7b23074 into kubernetes:master Nov 12, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation neolit123 authorized
Details
pull-kubeadm-kinder-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.