This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Move kubectl download to phase2 for vSphere CloudProvider #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For vSphere cloud provider kubectl was downloaded in phase1 since downloading in phase2 using ignition gave an error. Now, that is fixed this PR removes the downloading of kubectl from phase1 of vSphere Cloud Provider. Also, kubectl downloaded in phase2 was of v1.3.4 even though kubernetes cluster launched was of different version. This PR fixes that.
@mikedanese Can you please build the static binary and update at https://storage.googleapis.com/public-mikedanese-k8s/k8s/ignition? Also, I tested with master branch of ignition it fails therefore can you build binary for commit 6ff90ec7f985d783246fc429ea.