Skip to content
Permalink
Browse files

Fix the broken for loop including goroutine

Currently, all the funcs in the for loop are bound to the same
testCase.

Also remove extra newline from one expected message
  • Loading branch information...
haiyanmeng committed Jan 10, 2019
1 parent 08bee2c commit 408b5dbf5912cdd951c8196386042a4bc4d32e71
Showing with 2 additions and 1 deletion.
  1. +2 −1 test/e2e/common/runtime.go
@@ -172,7 +172,7 @@ while true; do sleep 1; done
TerminationMessagePolicy: v1.TerminationMessageFallbackToLogsOnError,
},
phase: v1.PodFailed,
message: Equal("DONE\n"),
message: Equal("DONE"),
},

{
@@ -201,6 +201,7 @@ while true; do sleep 1; done
message: Equal("OK"),
},
} {
testCase := testCase
It(fmt.Sprintf("should report termination message %s", testCase.name), func() {
testCase.container.Name = "termination-message-container"
c := ConformanceContainer{

0 comments on commit 408b5db

Please sign in to comment.
You can’t perform that action at this time.