defer close the rotated log open

kubernetes · Nov 12, 2021 · 47a2215 · 47a2215
1 parent 82e6210
commit 47a2215
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/pkg/kubelet/kuberuntime/logs/logs.go b/pkg/kubelet/kuberuntime/logs/logs.go
@@ -359,6 +359,7 @@ func ReadLogs(ctx context.Context, path, containerID string, opts *LogOptions, r
 						}
 						return fmt.Errorf("failed to open log file %q: %v", path, err)
 					}
+					defer newF.Close()
 					f.Close()
 					if err := watcher.Remove(f.Name()); err != nil && !os.IsNotExist(err) {
 						klog.Errorf("failed to remove file watch %q: %v", f.Name(), err)