From 8afdda103006435128a197e77168fe6deec71709 Mon Sep 17 00:00:00 2001 From: Di Xu Date: Fri, 31 Aug 2018 16:53:43 +0800 Subject: [PATCH] cleanup: remove unused options for rs controller --- hack/.golint_failures | 1 - pkg/controller/replicaset/BUILD | 5 +-- pkg/controller/replicaset/options/BUILD | 26 --------------- pkg/controller/replicaset/options/options.go | 35 -------------------- 4 files changed, 1 insertion(+), 66 deletions(-) delete mode 100644 pkg/controller/replicaset/options/BUILD delete mode 100644 pkg/controller/replicaset/options/options.go diff --git a/hack/.golint_failures b/hack/.golint_failures index 80aa3b0e3b41b..b44dc49228650 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -132,7 +132,6 @@ pkg/controller/podautoscaler pkg/controller/podautoscaler/metrics pkg/controller/podgc pkg/controller/replicaset -pkg/controller/replicaset/options pkg/controller/replication pkg/controller/resourcequota pkg/controller/route diff --git a/pkg/controller/replicaset/BUILD b/pkg/controller/replicaset/BUILD index be1df4d191c43..5d3a179e5a420 100644 --- a/pkg/controller/replicaset/BUILD +++ b/pkg/controller/replicaset/BUILD @@ -83,9 +83,6 @@ filegroup( filegroup( name = "all-srcs", - srcs = [ - ":package-srcs", - "//pkg/controller/replicaset/options:all-srcs", - ], + srcs = [":package-srcs"], tags = ["automanaged"], ) diff --git a/pkg/controller/replicaset/options/BUILD b/pkg/controller/replicaset/options/BUILD deleted file mode 100644 index c668f46a8bcdc..0000000000000 --- a/pkg/controller/replicaset/options/BUILD +++ /dev/null @@ -1,26 +0,0 @@ -package(default_visibility = ["//visibility:public"]) - -load( - "@io_bazel_rules_go//go:def.bzl", - "go_library", -) - -go_library( - name = "go_default_library", - srcs = ["options.go"], - importpath = "k8s.io/kubernetes/pkg/controller/replicaset/options", - deps = ["//vendor/github.com/spf13/pflag:go_default_library"], -) - -filegroup( - name = "package-srcs", - srcs = glob(["**"]), - tags = ["automanaged"], - visibility = ["//visibility:private"], -) - -filegroup( - name = "all-srcs", - srcs = [":package-srcs"], - tags = ["automanaged"], -) diff --git a/pkg/controller/replicaset/options/options.go b/pkg/controller/replicaset/options/options.go deleted file mode 100644 index 2cfc88a1cec1c..0000000000000 --- a/pkg/controller/replicaset/options/options.go +++ /dev/null @@ -1,35 +0,0 @@ -/* -Copyright 2016 The Kubernetes Authors. - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. -*/ - -package options - -import ( - "github.com/spf13/pflag" -) - -type ReplicasetControllerOptions struct { - ConcurrentRSSyncs int -} - -func NewReplicasetControllerOptions() ReplicasetControllerOptions { - return ReplicasetControllerOptions{ - ConcurrentRSSyncs: 5, - } -} - -func (o *ReplicasetControllerOptions) AddFlags(fs *pflag.FlagSet) { - fs.IntVar(&o.ConcurrentRSSyncs, "concurrent-replicaset-syncs", o.ConcurrentRSSyncs, "The number of replicasets that are allowed to sync concurrently. Larger number = more reponsive replica management, but more CPU (and network) load") -}