Skip to content
Permalink
Browse files

fix golint failures of pkg/kubelet

  • Loading branch information...
SataQiu committed Sep 2, 2019
1 parent b327a72 commit 6d6b0be36bfcd8faa2d4033d34feb71c341286cc
Showing with 5 additions and 6 deletions.
  1. +0 −1 hack/.golint_failures
  2. +5 −5 pkg/kubelet/reason_cache.go
@@ -110,7 +110,6 @@ pkg/kubeapiserver
pkg/kubeapiserver/options
pkg/kubectl/cmd/convert
pkg/kubectl/cmd/get
pkg/kubelet
pkg/kubelet/apis/config
pkg/kubelet/apis/config/v1beta1
pkg/kubelet/apis/deviceplugin/v1beta1
@@ -40,8 +40,8 @@ type ReasonCache struct {
cache *lru.Cache
}

// Reason is the cached item in ReasonCache
type reasonItem struct {
// ReasonItem is the cached item in ReasonCache
type ReasonItem struct {
Err error
Message string
}
@@ -64,7 +64,7 @@ func (c *ReasonCache) composeKey(uid types.UID, name string) string {
func (c *ReasonCache) add(uid types.UID, name string, reason error, message string) {
c.lock.Lock()
defer c.lock.Unlock()
c.cache.Add(c.composeKey(uid, name), reasonItem{reason, message})
c.cache.Add(c.composeKey(uid, name), ReasonItem{reason, message})
}

// Update updates the reason cache with the SyncPodResult. Only SyncResult with
@@ -93,13 +93,13 @@ func (c *ReasonCache) Remove(uid types.UID, name string) {
// Get gets error reason from the cache. The return values are error reason, error message and
// whether an error reason is found in the cache. If no error reason is found, empty string will
// be returned for error reason and error message.
func (c *ReasonCache) Get(uid types.UID, name string) (*reasonItem, bool) {
func (c *ReasonCache) Get(uid types.UID, name string) (*ReasonItem, bool) {
c.lock.Lock()
defer c.lock.Unlock()
value, ok := c.cache.Get(c.composeKey(uid, name))
if !ok {
return nil, false
}
info := value.(reasonItem)
info := value.(ReasonItem)
return &info, true
}

0 comments on commit 6d6b0be

Please sign in to comment.
You can’t perform that action at this time.