Skip to content
Permalink
Browse files

Merge pull request #65860 from sttts/sttts-high-ports

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

controller-managers: allow high ports in secure serving validation

Certain operating systems will select high port (>32768) when asked for a free port. This PR changes the validation to allow that.

Like #65833, but for controller managers.

```release-note
Allow kube- and cloud-controller-manager to listen on ports up to 65535.
```
  • Loading branch information...
Kubernetes Submit Queue
Kubernetes Submit Queue committed Jul 6, 2018
2 parents 9d11a47 + 13f6db1 commit 86b9a53226b1c9f9dce3ffb0133482f14709418b
Showing with 2 additions and 2 deletions.
  1. +2 −2 cmd/controller-manager/app/options/insecure_serving.go
@@ -53,8 +53,8 @@ func (s *InsecureServingOptions) Validate() []error {

errors := []error{}

if s.BindPort < 0 || s.BindPort > 32767 {
errors = append(errors, fmt.Errorf("--insecure-port %v must be between 0 and 32767, inclusive. 0 for turning off insecure (HTTP) port", s.BindPort))
if s.BindPort < 0 || s.BindPort > 65335 {
errors = append(errors, fmt.Errorf("--insecure-port %v must be between 0 and 65535, inclusive. 0 for turning off insecure (HTTP) port", s.BindPort))
}

return errors

0 comments on commit 86b9a53

Please sign in to comment.
You can’t perform that action at this time.