Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
storage e2e test: remove race when setting up loopback device
CI has shown occasional failures stemming from an -EBUSY when test/e2e/storage/persistent_volumes-local.go aka "PersistentVolumes-local" attempts to do losetup. Looking at the code, it has a clear race between querying the current free loopback device and later explicitly attempting to loopback setup a file at the queried device node. Losetup nowadays includes the logic to handle this for the user, if the '-f' option is used instead of naming the desired target loopback device explicitly. It is safe to presume a suitable losetup is present as the '-f' option is used elsewhere in the test, and it is safe to not record the allocated device, as it is already queried on the fly elsewhere in the test ahead of other commands which need to know an already created loopback device's node name. This patch should result in less flakes for this test case. Signed-off-by: Tim Pepper <tpepper@vmware.com>
- Loading branch information