From 9fd9faf55e9945a97c2b545d890ba7d4c34e2d5c Mon Sep 17 00:00:00 2001 From: Yuki Iwai Date: Fri, 8 Mar 2024 03:41:29 +0900 Subject: [PATCH] Job: Drop an incorrect comment in the job-controller Signed-off-by: Yuki Iwai --- pkg/controller/job/job_controller.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkg/controller/job/job_controller.go b/pkg/controller/job/job_controller.go index 8c6ea87999b47..0f9f7fa385fc8 100644 --- a/pkg/controller/job/job_controller.go +++ b/pkg/controller/job/job_controller.go @@ -1098,8 +1098,6 @@ func (jm *Controller) trackJobStatusAndRemoveFinalizers(ctx context.Context, job uncountedStatus.Succeeded = append(uncountedStatus.Succeeded, pod.UID) } } else if considerPodFailed || (jobCtx.finishedCondition != nil && !isSuccessCriteriaMetCondition(jobCtx.finishedCondition)) { - // If the number of succeeded pods have reached completions, the Job is declared completed, - // and any still running Pod should be deleted and considered Failed. // When the job is considered finished, every non-terminated pod is considered failed. ix := getCompletionIndex(pod.Annotations) if !jobCtx.uncounted.failed.Has(string(pod.UID)) && (!isIndexed || (ix != unknownCompletionIndex && ix < int(*jobCtx.job.Spec.Completions))) {