From 0b5456c13b3766ebc639bb9f03b2280218866bc6 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 17 Apr 2024 19:35:22 +0200 Subject: [PATCH] hack/verify-e2e-suites.sh: non-zero exit code when there were errors The script correctly reported errors, but did not return a non-zero exit code. Therefore errors would have been overlooked during pull-kubernetes-verify runs. --- hack/verify-e2e-suites.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hack/verify-e2e-suites.sh b/hack/verify-e2e-suites.sh index fc18621d9903..d6f635848365 100755 --- a/hack/verify-e2e-suites.sh +++ b/hack/verify-e2e-suites.sh @@ -31,6 +31,7 @@ cd "${KUBE_ROOT}" kube::util::ensure-temp-dir +res=0 for suite in $(git grep -l framework.AfterReadingAllFlags | grep -v -e ^test/e2e/framework -e ^hack | xargs -n 1 dirname | sort -u); do # Build a binary and run it in the root directory to get paths that are # relative to that instead of the package directory. @@ -41,5 +42,7 @@ for suite in $(git grep -l framework.AfterReadingAllFlags | grep -v -e ^test/e2e echo >&2 "ERROR: E2E test suite invocation failed for $suite." # shellcheck disable=SC2001 echo "$out" | sed -e 's/^/ /' + res=1 fi done +exit "$res"