From 445d7116113cb4476b4dc3f7c20a20a881744c84 Mon Sep 17 00:00:00 2001 From: Jon Sabo Date: Fri, 22 Mar 2019 16:40:40 -0500 Subject: [PATCH] Remove resync period --- pkg/controller/statefulset/stateful_set.go | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/pkg/controller/statefulset/stateful_set.go b/pkg/controller/statefulset/stateful_set.go index 43f07bf3362c..cf078dc20dc9 100644 --- a/pkg/controller/statefulset/stateful_set.go +++ b/pkg/controller/statefulset/stateful_set.go @@ -44,11 +44,6 @@ import ( "k8s.io/klog" ) -const ( - // period to relist statefulsets and verify pets - statefulSetResyncPeriod = 30 * time.Second -) - // controllerKind contains the schema.GroupVersionKind for this controller type. var controllerKind = apps.SchemeGroupVersion.WithKind("StatefulSet") @@ -121,7 +116,7 @@ func NewStatefulSetController( ssc.podLister = podInformer.Lister() ssc.podListerSynced = podInformer.Informer().HasSynced - setInformer.Informer().AddEventHandlerWithResyncPeriod( + setInformer.Informer().AddEventHandler( cache.ResourceEventHandlerFuncs{ AddFunc: ssc.enqueueStatefulSet, UpdateFunc: func(old, cur interface{}) { @@ -134,7 +129,6 @@ func NewStatefulSetController( }, DeleteFunc: ssc.enqueueStatefulSet, }, - statefulSetResyncPeriod, ) ssc.setLister = setInformer.Lister() ssc.setListerSynced = setInformer.Informer().HasSynced @@ -201,7 +195,7 @@ func (ssc *StatefulSetController) updatePod(old, cur interface{}) { curPod := cur.(*v1.Pod) oldPod := old.(*v1.Pod) if curPod.ResourceVersion == oldPod.ResourceVersion { - // Periodic resync will send update events for all known pods. + // In the event of a re-list we may receive update events for all known pods. // Two different versions of the same pod will always have different RVs. return } @@ -249,8 +243,7 @@ func (ssc *StatefulSetController) deletePod(obj interface{}) { // When a delete is dropped, the relist will notice a pod in the store not // in the list, leading to the insertion of a tombstone object which contains - // the deleted key/value. Note that this value might be stale. If the pod - // changed labels the new StatefulSet will not be woken up till the periodic resync. + // the deleted key/value. Note that this value might be stale. if !ok { tombstone, ok := obj.(cache.DeletedFinalStateUnknown) if !ok {