Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/etcd3: factor tests to accept storage.Interface #109833

Merged
merged 3 commits into from May 6, 2022
Merged

storage/etcd3: factor tests to accept storage.Interface #109833

merged 3 commits into from May 6, 2022

Conversation

stevekuznetsov
Copy link
Contributor

storage/etcd3: factor tests to accept storage.Interface

This commit simply factors the test functionality into functions that
accept storage.Interface.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

storage/etcd3: move reusable tests to importable files

These can't live in _test.go files, or others won't be able to re-use
them as you can't import from test files.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/kind cleanup
/sig api-machinery

NONE

/assign @wojtek-t
/cc @liggitt @lavalamp

@stevekuznetsov
storage/etcd3: factor tests to accept storage.Interface
117f674 
This commit simply factors the test functionality into functions that
accept `storage.Interface`.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 5, 2022
@k8s-ci-robot k8s-ci-robot requested a review from lavalamp May 5, 2022 16:28
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 5, 2022
@k8s-ci-robot k8s-ci-robot requested a review from liggitt May 5, 2022 16:28
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 5, 2022
@stevekuznetsov
storage/etcd3: move reusable tests to importable files
0bfeb72 
These can't live in `_test.go` files, or others won't be able to re-use
them as you can't import from test files.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov mentioned this pull request May 5, 2022
Open
46 tasks
@stevekuznetsov
Copy link
Contributor Author

Part of #109831

@leilajal
Copy link
Contributor

leilajal commented May 5, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 5, 2022
@stevekuznetsov
storage/testing: wire things back together with imports
4ff560e 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
Copy link
Contributor Author

@liggitt @wojtek-t updated to use the storage/testing package. We can revert all of the exported helper methods when the rest of the tests are moved over.

@stevekuznetsov
Copy link
Contributor Author

Flake on TestDSCUpdatesPodLabelAfterDedupCurHistories
/retest

@wojtek-t
Copy link
Member

wojtek-t commented May 6, 2022

Thanks - this looks great.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@stevekuznetsov
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ga-only-parallel

@k8s-ci-robot k8s-ci-robot merged commit f745774 into kubernetes:master May 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stevekuznetsov @leilajal @wojtek-t @k8s-ci-robot @liggitt