Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce load of Job integration test #114261

Merged
merged 1 commit into from Dec 13, 2022

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Dec 2, 2022

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

The timeout for this test is only 30s, which in 1.23 is sometimes not enough to process all the pods.
Even after this change, we are still testing with lots of pods, which should be enough to spot potential problems.

Which issue(s) this PR fixes:

Fixes #114259

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Test-only change.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. labels Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Dec 2 15:44:06 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 2, 2022
@alculquicondor
Copy link
Member Author

/sig apps
/assign @aojea

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2022
@aojea
Copy link
Member

aojea commented Dec 2, 2022

/lgtm
/approve

ping @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Member

aojea commented Dec 2, 2022

/assign @liggitt

for advice on how to handle this

@liggitt
Copy link
Member

liggitt commented Dec 2, 2022

/assign @liggitt

for advice on how to handle this

The change lgtm, no strong opinions about merge order between this and release branches, will defer to release managers on whether they want to merge to release-1.23 to clean up signal there first

Change-Id: If99856aa6640375a8a9feff13fa213d4f974a99a
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@alculquicondor
Copy link
Member Author

/hold
for successful runs on #114264

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2022
@alculquicondor
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2022
@alculquicondor
Copy link
Member Author

@aojea for lgtm

@aojea
Copy link
Member

aojea commented Dec 13, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 19a0aaa into kubernetes:master Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 13, 2022
k8s-ci-robot added a commit that referenced this pull request Dec 19, 2022
…of-#114261-upstream-release-1.23

Automated cherry pick of #114261: Reduce load of Job integration test
k8s-ci-robot added a commit that referenced this pull request Dec 19, 2022
…of-#114261-upstream-release-1.26

Automated cherry pick of #114261: Reduce load of Job integration test
k8s-ci-robot added a commit that referenced this pull request Dec 19, 2022
…of-#114261-upstream-release-1.25

Automated cherry pick of #114261: Reduce load of Job integration test
k8s-ci-robot added a commit that referenced this pull request Dec 19, 2022
…of-#114261-upstream-release-1.24

Automated cherry pick of #114261: Reduce load of Job integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s.io/kubernetes/test/integration/job: TestFinalizersClearedWhenBackoffLimitExceeded flakes in 1.23
4 participants