Codegen: subproject cleanups and chdir #116281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/code-generation
sig/api-machinery
thockin
force-pushed
the
codegen_subproject_chdir
branch
from
0b0a3ec to
dcd9c53
Compare
Contributor
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
thockin
force-pushed
the
codegen_subproject_chdir
branch
from
dcd9c53 to
6efa410
Compare
Member
Author
|
/retest |
This moves the hack/ directory and scripts to the examples dir, which is a distinct module. This avoids some Go unpleasantness around module boundaries and just makes more sense.
thockin
force-pushed
the
codegen_subproject_chdir
branch
from
6efa410 to
e608b35
Compare
k8s-ci-robot
added
size/M
Member
Author
|
Rebased |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aojea
reviewed
Apr 11, 2023
hack/update-codegen.sh
Outdated
Member
There was a problem hiding this comment.
why is this inside the loop? is not always the same value?
This makes it feel more like an API to be used in other repos (which is really what it is for).
thockin
commented
Apr 11, 2023
Member
Author
thockin
left a comment
thockin
left a comment
There was a problem hiding this comment.
Will push a new update
hack/update-codegen.sh
Outdated
thockin
force-pushed
the
codegen_subproject_chdir
branch
from
e608b35 to
73eb7c0
Compare
Member
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
Contributor
|
LGTM label has been added. Git tree hash: f3094de36b174760dc12094ce20e9c07e7414771
|
thockin
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three related commits, building on #116280
Move the hack/ directory and scripts within k8s.io/code-generator/examples to be more self-contained, and fix the fallout.
When running subproject generators, chdir and pretend it's a standalone repo (as an external user would use it)
Indent the subproject generation logs for easier reading.
/kind cleanup