Skip to content

kubeadm: increase ut coverage app/componentconfigs #122642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jan 10, 2024
Merged

kubeadm: increase ut coverage app/componentconfigs #122642

k8s-ci-robot merged 1 commit into from
Jan 10, 2024

Conversation

@my-git9
Copy link
Member

@my-git9 my-git9 commented Jan 8, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

kubeadm: increase ut coverage app/componentconfigs

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2024
@my-git9 my-git9 force-pushed the componentconfigs-ut-q branch from b1be742 to 4287112 Compare January 8, 2024 11:50
neolit123
neolit123 reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added a couple of comments.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@neolit123
Copy link
Member

neolit123 commented Jan 8, 2024

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 8, 2024
@my-git9 my-git9 force-pushed the componentconfigs-ut-q branch from 4287112 to 954d901 Compare January 8, 2024 14:27
@my-git9 my-git9 requested a review from neolit123 January 8, 2024 14:28
neolit123
neolit123 reviewed Jan 8, 2024
View reviewed changes
@my-git9 my-git9 force-pushed the componentconfigs-ut-q branch from 954d901 to 39a73a8 Compare January 9, 2024 13:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
@my-git9 my-git9 force-pushed the componentconfigs-ut-q branch from 39a73a8 to bb6a3a3 Compare January 9, 2024 13:37
@my-git9 my-git9 requested a review from neolit123 January 9, 2024 13:37
neolit123
neolit123 reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old test also include multiple errors:
https://github.com/kubernetes/kubernetes/compare/954d901264ecb9899196d0cfc8312dfa0a2343fe..39a73a8f76c340e7dd32fe66cea0a68b3519dd9b#diff-a8f5d69065604f0e857faec41f0b9b550c2851d22cd5698ae50a98aca0dd6e30L96

do we not need this any more?

@my-git9
kubeadm: increase ut coverage app/componentconfigs
1a69fd4 
Signed-off-by: xin.li <xin.li@daocloud.io>
@my-git9 my-git9 force-pushed the componentconfigs-ut-q branch from bb6a3a3 to 1a69fd4 Compare January 9, 2024 13:52
@my-git9 my-git9 requested a review from neolit123 January 9, 2024 13:53
neolit123
neolit123 reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 9, 2024

LGTM label has been added.

Git tree hash: 1ce03fcc3477919b8eacdfe21a3bbed2b163e66f

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: my-git9, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@my-git9
Copy link
Member Author

my-git9 commented Jan 9, 2024

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 331e556 into kubernetes:master Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SataQiu SataQiu Awaiting requested review from SataQiu

1 more reviewer

@neolit123 neolit123 neolit123 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@neolit123 neolit123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.30

Development

Successfully merging this pull request may close these issues.

3 participants

@my-git9 @neolit123 @k8s-ci-robot