e2e_node: consolidated NFSServer APIs. #128096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Contributor
Author
|
/sig node |
k8s-ci-robot
added
sig/node
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: f6b0d9889dff749f20fdb8bbcf33acb9c9a191d1
|
k8s-ci-robot
added
area/e2e-test-framework
Contributor
Author
|
/test pull-kubernetes-node-arm64-ubuntu-serial-gce |
Contributor
Author
Contributor
Author
|
/cc @jsafrane |
Contributor
|
/test |
Contributor
|
@kannon92: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/test pull-kubernetes-node-crio-cgrpv2-e2e Looking at this I see MirrorPods as node conformance. |
Contributor
Author
|
/test pull-kubernetes-node-arm64-ubuntu-serial-gc |
Contributor
|
@bart0sh: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
bart0sh
force-pushed
the
PR161-e2e_node-consolidate-NFSServer-APIs
branch
from
32d5896 to
b69f410
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
Author
|
/test pull-kubernetes-node-crio-cgrpv2-e2e |
1 similar comment
Contributor
Author
|
/test pull-kubernetes-node-crio-cgrpv2-e2e |
Member
|
/test pull-kubernetes-node-arm64-ubuntu-serial-gce |
Contributor
Author
|
/retest |
Contributor
|
@bart0sh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/skip |
Contributor
|
/cc @SergeyKanzhelev |
Member
SergeyKanzhelev
left a comment
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
/lgtm
already approved before. Re-lgtm-ing
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: a3c57e4a60713e7f2537b09bb45fccd6f0663597
|
Contributor
Author
|
/triage accepted /assign @SergeyKanzhelev @mrunalp |
k8s-ci-robot
added
triage/accepted
Member
|
/approve |
Member
|
/assign @jsafrane |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bart0sh, dchen1107, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Consolidate NFSServer APIs.
This is a follow up for the #128066
Does this PR introduce a user-facing change?
/sig-node
/cc @SergeyKanzhelev @pacoxu