-
Notifications
You must be signed in to change notification settings - Fork 41.9k
Copy ParseCgroupFileUnified and Drop rest of containerd/cgroups #128473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy ParseCgroupFileUnified and Drop rest of containerd/cgroups #128473
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -0,0 +1,50 @@ | |||
| /* | |||
| Copyright The containerd Authors. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied the entire file, so keeping their copyright
| @@ -0,0 +1,64 @@ | |||
| /* | |||
| Copyright 2024 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied just a couple of methods into a new file, so just adding ours.
|
/assign @SergeyKanzhelev @mrunalp @tzneal |
|
/priority important-soon |
e388fe6 to
d1ed74d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm thanks for picking this up! holding to let CI run and anyone else chime in |
|
LGTM label has been added. Git tree hash: 1058bfa345839bb50750c2a67c87f7c8643b7116
|
|
Weird that i can't repro the failure locally. could it be a mac vs linux issue? digging deeper |
d1ed74d to
c9deb43
Compare
yep. i see the failure on linux... will think about how to do this better in my long TODO later :) for now, i had the wrong file name for the tests! |
c9deb43 to
b3a891d
Compare
b3a891d to
dd9e1fb
Compare
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dd9e1fb to
e86d02b
Compare
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 220f90d1a75692e105b1c8074b24e4f97499d120
|
Related to discussion in #128157 - Let's ensure we use ONLY one cgroups library.
Here in this PR we can keep a temporary copy until we get a longer term solution in
runc's cgroup library, see opencontainers/runc#4497What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: