`kubectl apply deployment -f` doesn't accept label/selector changes

[lavalamp]

I got errors complaining about the selector and labels not matching even if I explicitly specified both. Showed @janetkuo.

[janetkuo]

To reproduce:

First create a Deployment via apply -f

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: nginx-deployment
spec:
  replicas: 3
  template:
    metadata:
      labels:
        app: nginx
        test: abcd
    spec:
      containers:
      - name: nginx
        image: nginx:1.7.9
        ports:
        - containerPort: 80

Then remove any of the labels in the file (and optionally specify the selector), and then apply -f

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: nginx-deployment
spec:
  selector:
    matchLabels:
      app: nginx
  replicas: 3
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: nginx:1.7.9
        ports:
        - containerPort: 80

Error message:

proto: no encoder for TypeMeta unversioned.TypeMeta [GetProperties]
proto: tag has too few fields: "-"
proto: no coders for struct *reflect.rtype
proto: no encoder for sec int64 [GetProperties]
proto: no encoder for nsec int32 [GetProperties]
proto: no encoder for loc *time.Location [GetProperties]
proto: no encoder for Time time.Time [GetProperties]
proto: no encoder for InitContainers []v1.Container [GetProperties]
proto: no coders for intstr.Type
proto: no encoder for Type intstr.Type [GetProperties]
The Deployment "nginx-deployment" is invalid.
spec.template.metadata.labels: Invalid value: {"app":"nginx"}: `selector` does not match template `labels`

@kubernetes/kubectl @adohe

[smarterclayton]

Is there a bug already open for all that proto crap? I had not seen that
showing up before - I would not expect it.

On May 24, 2016, at 6:29 PM, Janet Kuo notifications@github.com wrote:

To reproduce:

First create a Deployment via apply -f

apiVersion: extensions/v1beta1kind: Deploymentmetadata:
name: nginx-deploymentspec:
replicas: 3
template:
metadata:
labels:
app: nginx
test: abcd
spec:
containers:
- name: nginx
image: nginx:1.7.9
ports:
- containerPort: 80

Then remove any of the labels in the file, and apply -f

$ kubectl apply -f docs/user-guide/nginx-deployment.yaml proto: no
encoder for TypeMeta unversioned.TypeMeta [GetProperties]proto: tag
has too few fields: "-"proto: no coders for struct
*reflect.rtypeproto: no encoder for sec int64 [GetProperties]proto: no
encoder for nsec int32 [GetProperties]proto: no encoder for loc
*time.Location [GetProperties]proto: no encoder for Time time.Time
[GetProperties]proto: no encoder for InitContainers []v1.Container
[GetProperties]proto: no coders for intstr.Typeproto: no encoder for
Type intstr.Type [GetProperties]The Deployment "nginx-deployment" is
invalid.spec.template.metadata.labels: Invalid value: {"test":"abcd"}:
selector does not match template labels

@kubernetes/kubectl https://github.com/orgs/kubernetes/teams/kubectl
@adohe https://github.com/AdoHe

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly or view it on GitHub
#26202 (comment)

[janetkuo]

The problem is that the apply annotation didn't record .spec.selector when it's defaulted from .spec.template.labels and it caused problems when calculating diff:

kubectl.kubernetes.io/last-applied-configuration: '{"kind":"Deployment","apiVersion":"extensions/v1beta1","metadata":{"name":"nginx-deployment","creationTimestamp":null},"spec":{"replicas":3,"template":{"metadata":{"creationTimestamp":null,"labels":{"app":"nginx","test":"abcd"}},"spec":{"containers":[{"name":"nginx","image":"nginx:1.7.9","ports":[{"containerPort":80}],"resources":{}}]}},"strategy":{}},"status":{}}'

[adohe-zz]

That's because the last-applied-configuration is just the resource content read from user input when we use apply to create resource. Also the .spec.selector is derived from .spec.template.labels rule is not used in client side.

[adohe-zz]

@janetkuo I am considering adding the default .spec.selector to last-applied-configuration annotation WDYT?

[therc]

We've been bitten by this for a service:

The Service "labeler" is invalid.

* metadata.resourceVersion: Invalid value: "": must be specified for an update
* spec.clusterIP: Invalid value: "": field is immutable

I just nuked the last-applied-configuration annotation and the change applied successfully.

[therc]

And before that error, there was the very same sequence of proto errors.