Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cAdvisor in 1.4 does not work on RHEL #32917

Closed
eparis opened this issue Sep 16, 2016 · 11 comments
Closed

cAdvisor in 1.4 does not work on RHEL #32917

eparis opened this issue Sep 16, 2016 · 11 comments
Labels
area/kubelet lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@eparis
Copy link
Contributor

eparis commented Sep 16, 2016

see: google/cadvisor#1461

This issue is purely for tracking purposes.

@eparis eparis added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 16, 2016
@eparis eparis added this to the v1.4 milestone Sep 16, 2016
@k8s-github-robot k8s-github-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 16, 2016
@dchen1107
Copy link
Member

Both @derekwaynecarr and I think this shouldn't be the blocker for 1.4 since it only impacts running cAdvisor or Kubelet in a container. I can be convinced though.

@eparis eparis added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 17, 2016
@pwittrock pwittrock modified the milestones: v1.4-nonblocking, v1.4 Sep 19, 2016
@four43
Copy link

four43 commented Sep 21, 2016

This would break usage in CoreOS too, no? They have provisioning docs that run the Kubelet as a container with the rkt engine.

https://github.com/coreos/coreos-kubernetes

@dchen1107
Copy link
Member

cc/ @philips @euank on CoreOS use case.

@philips
Copy link
Contributor

philips commented Sep 21, 2016

cc @aaronlevy @pbx0

@philips
Copy link
Contributor

philips commented Sep 21, 2016

@aaronlevy didn't see any failures in testing beta.8 but the way we run kubelet under rkt is different than I think the issue referred does cAdvisor in a docker container.

We will see if beta.9 turns anything up.

@aaronlevy
Copy link
Contributor

This specific issue does not seem to affect CoreOS installs (tested beta.8 & beta.9).

@derekwaynecarr
Copy link
Member

The fix was merged to cAdvisor

google/cadvisor#1476

On Wednesday, September 21, 2016, Aaron Levy notifications@github.com
wrote:

This specific issue does not seem to affect CoreOS installs (tested beta.8
& beta.9).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#32917 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF8dbFiLNGgYpLrmoli0hUzd7AlJLx20ks5qseSagaJpZM4J_aGa
.

@derekwaynecarr
Copy link
Member

The backport into cAdvisor v0.24 is here: google/cadvisor#1478

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 18, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubelet lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests