Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take kubectl apply out of Alpha and into Beta

Closed
1 of 2 tasks
mikedanese opened this issue Oct 6, 2016 · 22 comments
Closed
1 of 2 tasks

Take kubectl apply out of Alpha and into Beta #34274

mikedanese opened this issue Oct 6, 2016 · 22 comments
Labels
area/app-lifecycle area/declarative-configuration area/kubectl needs-triage priority/important-soon sig/cli
Projects
UX - Kubectl Continued Development an...

Comments

@mikedanese
Copy link
Member

mikedanese commented Oct 6, 2016 •
edited

  • Fully document behavior
  • Prune all restmappings, not just those provided

cc @pwittrock
@MrHohn MrHohn mentioned this issue Oct 12, 2016
Merged
@pwittrock pwittrock added the priority/backlog label Oct 13, 2016
@MrHohn
Copy link
Member

MrHohn commented Oct 19, 2016 •
edited

Sorry to bother, I want to know what is the plan for "Prune all restmappings"? I think addon-manager will need this feature (at least need to also prune given additional restmappings?).

@mikedanese mikedanese added priority/important-soon and removed priority/backlog labels Oct 19, 2016
@mikedanese
Copy link
Member Author

mikedanese commented Oct 19, 2016

I have not started working on it. I can take a look or you can if you want.

@mikedanese mikedanese self-assigned this Oct 19, 2016
@MrHohn
Copy link
Member

MrHohn commented Oct 19, 2016

Sure, I can take a look at this if it is not complicated.

I wanna follow the plan you proposed before: add a --type flag to modified the visitedRESTMappings

@MrHohn MrHohn mentioned this issue Oct 20, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Nov 4, 2016
Merge pull request #35220 from MrHohn/kubectl-apply-type
e4edd81 
Automatic merge from submit-queue

Implement --prune-whitelist(-w) flag to overwrite default whitelist for --prune

From #34274.

Updates:

As suggested, the new commits implement a default whitelist for `kubectl apply --prune`, which could be overwritten by using `--prune-whitelist`or `-w` flag. The default whitelist and example as below.

Also supports `--dry-run` for `--prune` to fix #35222.

whitelist:

```
type pruneResource struct {
    group      string
    version    string
    kind       string
    namespaced bool
}

*pruneResources = []pruneResource{
    {"", "v1", "ConfigMap", true},
    {"", "v1", "Endpoints", true},
    {"", "v1", "Namespace", false},
    {"", "v1", "PersistentVolumeClaim", true},
    {"", "v1", "PersistentVolume", false},
    {"", "v1", "Pod", true},
    {"", "v1", "ReplicationController", true},
    {"", "v1", "Secret", true},
    {"", "v1", "Service", true},
    {"batch", "v1", "Job", true},
    {"extensions", "v1beta1", "DaemonSet", true},
    {"extensions", "v1beta1", "Deployment", true},
    {"extensions", "v1beta1", "HorizontalPodAutoscaler", true},
    {"extensions", "v1beta1", "Ingress", true},
    {"extensions", "v1beta1", "ReplicaSet", true},
    {"apps", "v1beta1", "StatefulSet", true},
}
```

example:

```
$ kubectl apply -f /path/to/file --prune -l test=true \
      -w core/v1/Pod \
      -w core/v1/Service \
      -w extensions/v1beta1/Deployment 
```

@mikedanese
@bgrant0607
Copy link
Member

bgrant0607 commented Nov 17, 2016

cc @ymqytw @pwittrock

@pwittrock
Copy link
Member

pwittrock commented Nov 17, 2016

@MrHohn Can we close this issue?

@MrHohn
Copy link
Member

MrHohn commented Nov 17, 2016

@pwittrock Sure. --prune is not well documented yet, but I think #35234 is also tracking this.

@pwittrock pwittrock mentioned this issue Nov 17, 2016
Open
32 tasks
@MrHohn
Copy link
Member

MrHohn commented Nov 23, 2016

Actually I think we might want to keep this issue open. There is an Alpha Disclaimer comment in the code, which has a pointer to this issue.
Plus this --prune feature indeed needs to be refined, see comments here and here.

Could we update the contents on top and keep it open?

@pwittrock @mikedanese

@pwittrock pwittrock changed the title Polish outstanding issues with kubeclt apply --prune Take kubectl apply out of Alpha and into Beta Nov 23, 2016
@pwittrock
Copy link
Member

pwittrock commented Nov 23, 2016

SGTM

@k8s-github-robot k8s-github-robot added the needs-sig label May 31, 2017
@xiangpengzhao
Copy link
Member

xiangpengzhao commented Jun 24, 2017

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli label Jun 24, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig label Jun 24, 2017
@fejta-bot
Copy link

fejta-bot commented Jan 6, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale label Jan 6, 2018
@bgrant0607
Copy link
Member

bgrant0607 commented Jan 23, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale label Jan 23, 2018
@fejta-bot
Copy link

fejta-bot commented Apr 23, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale label Apr 23, 2018
@fejta-bot
Copy link

fejta-bot commented May 23, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten and removed lifecycle/stale labels May 23, 2018
@fejta-bot
Copy link

fejta-bot commented Jun 22, 2018

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@akavel
Copy link

akavel commented Nov 12, 2019 •
edited

Guys, so this is now both "priority/important-soon", and "lifecycle/rotten"; can you make a grown-up decision on it and remove one of those labels? doesn't make much sense to see them both applied. The docs still contain the section warning that this is alpha functionality, and code in master branch still links to this issue! I guess maybe you want to also clean up the situation between this issue and #35234?

@afirth
Copy link
Member

afirth commented May 26, 2021

still here some months later. not sure what to do about it but all the warnings are still around and i guess it violates the alpha policy. Shame, because it can be really helpful when using things like skaffold and kustomize.
/reopen

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 26, 2021

@afirth: Reopened this issue.

In response to this:

still here some months later. not sure what to do about it but all the warnings are still around and i guess it violates the alpha policy. Shame, because it can be really helpful when using things like skaffold and kustomize.
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this May 26, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 26, 2021

@mikedanese: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage label May 26, 2021
@fejta-bot
Copy link

fejta-bot commented Jun 25, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 25, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clintmod
Copy link

clintmod commented Jun 28, 2021

/reopen
/remove-lifecycle rotten

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 28, 2021

@clintmod: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/app-lifecycle area/declarative-configuration area/kubectl needs-triage priority/important-soon sig/cli
Projects
UX - Kubectl Continued Development an...
Debt
Milestone
No milestone
Development

No branches or pull requests