Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTake kubectl apply out of Alpha and into Beta #34274
Comments
|
Sorry to bother, I want to know what is the plan for "Prune all restmappings"? I think addon-manager will need this feature (at least need to also prune given additional restmappings?). |
|
I have not started working on it. I can take a look or you can if you want. |
|
Sure, I can take a look at this if it is not complicated. I wanna follow the plan you proposed before: add a |
Automatic merge from submit-queue Implement --prune-whitelist(-w) flag to overwrite default whitelist for --prune From #34274. Updates: As suggested, the new commits implement a default whitelist for `kubectl apply --prune`, which could be overwritten by using `--prune-whitelist`or `-w` flag. The default whitelist and example as below. Also supports `--dry-run` for `--prune` to fix #35222. whitelist: ``` type pruneResource struct { group string version string kind string namespaced bool } *pruneResources = []pruneResource{ {"", "v1", "ConfigMap", true}, {"", "v1", "Endpoints", true}, {"", "v1", "Namespace", false}, {"", "v1", "PersistentVolumeClaim", true}, {"", "v1", "PersistentVolume", false}, {"", "v1", "Pod", true}, {"", "v1", "ReplicationController", true}, {"", "v1", "Secret", true}, {"", "v1", "Service", true}, {"batch", "v1", "Job", true}, {"extensions", "v1beta1", "DaemonSet", true}, {"extensions", "v1beta1", "Deployment", true}, {"extensions", "v1beta1", "HorizontalPodAutoscaler", true}, {"extensions", "v1beta1", "Ingress", true}, {"extensions", "v1beta1", "ReplicaSet", true}, {"apps", "v1beta1", "StatefulSet", true}, } ``` example: ``` $ kubectl apply -f /path/to/file --prune -l test=true \ -w core/v1/Pod \ -w core/v1/Service \ -w extensions/v1beta1/Deployment ``` @mikedanese
bgrant0607
added
area/app-lifecycle
area/kubectl
and removed
area/controller-manager
labels
|
cc @ymqytw @pwittrock |
|
@MrHohn Can we close this issue? |
|
@pwittrock Sure. |
|
Actually I think we might want to keep this issue open. There is an Alpha Disclaimer comment in the code, which has a pointer to this issue. Could we update the contents on top and keep it open? |
pwittrock
changed the title
|
SGTM |
|
/sig cli |
|
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
|
/remove-lifecycle stale |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
Guys, so this is now both |
cc @pwittrock