New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server component commands and hyperkube should be using cobra #34732
Comments
@kubernetes/kubectl |
Also relevant here: #31432 |
I will start update server components. |
@ncdc I will take a look, thanks :) |
/sig cli |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
/remove-lifecycle stale |
see #58190 |
Automatic merge from submit-queue (batch tested with PRs 58209, 57561, 58405). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. make the kubelet cobra command complete This pull attempts a move from the cmd/kubelet to the cobra command where it can re-used. /assign @mtaufen /assign @liggitt @ncdc fyi xref: #34732 ```release-note NONE ```
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. switch hyperkube to cobra This makes use of cobra to layer the commands with a library that already supports composing commands. Fixes #34732 ```release-note NONE ```
As best I can tell, our server component commands only use cobra as a means of generating docs and man pages. We should refactor our commands so that they use cobra the right way (i.e., they have
Run
functions that actually do things). As a result, we can make hyperkube leaner by reusing the cobra commands once they're refactored correctly.Server component command tasks:
Hyperkube tasks:
Server
usage withcobra.Command
cc @smarterclayton @bgrant0607 @thockin @eparis @fabianofranz @deads2k @liggitt @sttts
The text was updated successfully, but these errors were encountered: