Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server component commands and hyperkube should be using cobra #34732

Closed
15 tasks done
ncdc opened this issue Oct 13, 2016 · 9 comments
Closed
15 tasks done

Server component commands and hyperkube should be using cobra #34732

ncdc opened this issue Oct 13, 2016 · 9 comments
Assignees
@adohe-zz
Labels
area/apiserver area/controller-manager area/kube-proxy area/kubelet kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@ncdc
Copy link
Member

ncdc commented Oct 13, 2016 •
edited by deads2k

As best I can tell, our server component commands only use cobra as a means of generating docs and man pages. We should refactor our commands so that they use cobra the right way (i.e., they have Run functions that actually do things). As a result, we can make hyperkube leaner by reusing the cobra commands once they're refactored correctly.

Server component command tasks:

Hyperkube tasks:

  • replace Server usage with cobra.Command
  • federation-apiserver
  • federation-controller-manager
  • kube-apiserver
  • kube-controller-manager
  • kube-proxy
  • kube-scheduler
  • kubelet

cc @smarterclayton @bgrant0607 @thockin @eparis @fabianofranz @deads2k @liggitt @sttts
@ncdc ncdc changed the title Commands and hyperkube should be using cobra Server commands and hyperkube should be using cobra Oct 13, 2016
@ncdc ncdc changed the title Server commands and hyperkube should be using cobra Server component commands and hyperkube should be using cobra Oct 13, 2016
@k8s-github-robot k8s-github-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 13, 2016
@smarterclayton
Copy link
Contributor

@kubernetes/kubectl

@luxas
Copy link
Member

luxas commented Oct 13, 2016

Also relevant here: #31432

@adohe-zz
Copy link

I will start update server components.

@ncdc
Copy link
Member Author

ncdc commented Oct 14, 2016

@adohe thanks! If you want to see an example, here's what I did for kube-proxy (although it's part of a larger POC, so we can refactor kube-proxy separate from the POC, and I'll rebase as needed): #34727

@adohe-zz
Copy link

@ncdc I will take a look, thanks :)

@bgrant0607 bgrant0607 added team/ux kind/documentation Categorizes issue or PR as related to documentation. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/kubelet area/kube-proxy area/controller-manager and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 21, 2016
@pwittrock pwittrock added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 17, 2016
@ncdc ncdc mentioned this issue Apr 27, 2017
Merged
@thockin thockin added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed sig/network Categorizes an issue or PR as relevant to SIG Network. labels May 16, 2017
This was referenced May 19, 2017
Closed
Closed
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@0xmichalis
Copy link
Contributor

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jun 24, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 24, 2017
This was referenced Dec 28, 2017
Closed
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2017
@ncdc
Copy link
Member Author

ncdc commented Jan 17, 2018

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2018
@liggitt
Copy link
Member

liggitt commented Jan 17, 2018

see #58190

@liggitt liggitt mentioned this issue Jan 17, 2018
Closed
@ncdc ncdc mentioned this issue Jan 17, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue Jan 18, 2018
Merge pull request #58405 from deads2k/kubelet-01-start
7f6dae7 
Automatic merge from submit-queue (batch tested with PRs 58209, 57561, 58405). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

make the kubelet cobra command complete

This pull attempts a move from the cmd/kubelet to the cobra command where it can re-used.

/assign @mtaufen 
/assign @liggitt 
@ncdc fyi

xref: #34732

```release-note
NONE
```
@deads2k deads2k mentioned this issue Jan 26, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue Jan 26, 2018
Merge pull request #58408 from deads2k/hyperkube-01-fix
6177b42 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

switch hyperkube to cobra

This makes use of cobra to layer the commands with a library that already supports composing commands.

Fixes #34732

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adohe-zz adohe-zz

Labels
area/apiserver area/controller-manager area/kube-proxy area/kubelet kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests