/kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server component commands and hyperkube should be using cobra #34732

Closed
ncdc opened this Issue Oct 13, 2016 · 9 comments

Comments

Assignees

@adohe adohe

Labels
Projects
None yet
Milestone
No milestone
@ncdc
Member

ncdc commented Oct 13, 2016 •
edited by deads2k

As best I can tell, our server component commands only use cobra as a means of generating docs and man pages. We should refactor our commands so that they use cobra the right way (i.e., they have Run functions that actually do things). As a result, we can make hyperkube leaner by reusing the cobra commands once they're refactored correctly.

Server component command tasks:

  • federation-apiserver
  • federation-controller-manager
  • kube-apiserver
  • kube-controller-manager #58398
  • kube-proxy #34727
  • kube-scheduler #52562
  • kubelet

Hyperkube tasks:

  • replace Server usage with cobra.Command
  • federation-apiserver
  • federation-controller-manager
  • kube-apiserver
  • kube-controller-manager
  • kube-proxy
  • kube-scheduler
  • kubelet

cc @smarterclayton @bgrant0607 @thockin @eparis @fabianofranz @deads2k @liggitt @sttts

@ncdc ncdc changed the title from Commands and hyperkube should be using cobra to Server commands and hyperkube should be using cobra Oct 13, 2016

@ncdc ncdc changed the title from Server commands and hyperkube should be using cobra to Server component commands and hyperkube should be using cobra Oct 13, 2016

@k8s-merge-robot k8s-merge-robot added area/apiserver sig/api-machinery labels Oct 13, 2016

@smarterclayton

This comment has been minimized.

Sign in to view
Contributor

smarterclayton commented Oct 13, 2016

@kubernetes/kubectl
@luxas

This comment has been minimized.

Sign in to view
Member

luxas commented Oct 13, 2016

Also relevant here: #31432
@adohe

This comment has been minimized.

Sign in to view
Member

adohe commented Oct 13, 2016

I will start update server components.
@ncdc

This comment has been minimized.

Sign in to view
Member

ncdc commented Oct 14, 2016

@adohe thanks! If you want to see an example, here's what I did for kube-proxy (although it's part of a larger POC, so we can refactor kube-proxy separate from the POC, and I'll rebase as needed): #34727
@adohe

This comment has been minimized.

Sign in to view
Member

adohe commented Oct 14, 2016

@ncdc I will take a look, thanks :)

@bgrant0607 bgrant0607 added team/ux kind/documentation kind/cleanup area/kubelet area/kube-proxy area/controller-manager and removed sig/api-machinery labels Oct 21, 2016

@bgrant0607 bgrant0607 removed the component/scheduler label Nov 15, 2016

@pwittrock pwittrock assigned adohe Nov 17, 2016

@pwittrock pwittrock added the priority/backlog label Nov 17, 2016

@ncdc ncdc referenced this issue Apr 27, 2017

Merged

Refactor kube-proxy configuration #34727

@thockin thockin added sig/network and removed sig/network labels May 16, 2017

This was referenced May 19, 2017

Closed
Closed

@k8s-merge-robot k8s-merge-robot added the needs-sig label May 31, 2017

@kargakis

This comment has been minimized.

Sign in to view
Member

kargakis commented Jun 24, 2017

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli label Jun 24, 2017

@k8s-merge-robot k8s-merge-robot removed the needs-sig label Jun 24, 2017

This was referenced Dec 28, 2017

Closed
Closed
@fejta-bot

This comment has been minimized.

Sign in to view

fejta-bot commented Dec 30, 2017

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale label Dec 30, 2017

@ncdc

This comment has been minimized.

Sign in to view
Member

ncdc commented Jan 17, 2018

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen and removed lifecycle/stale labels Jan 17, 2018

@liggitt

This comment has been minimized.

Sign in to view
Member

liggitt commented Jan 17, 2018

see #58190

@liggitt liggitt referenced this issue Jan 17, 2018

Closed

Hyperkube starts the Kubelet differently, and diverges from bootstrap logic as a result #58190

@ncdc ncdc referenced this issue Jan 17, 2018

Merged

make the kubelet cobra command complete #58405

k8s-merge-robot added a commit that referenced this issue Jan 18, 2018

@k8s-merge-robot
Merge pull request #58405 from deads2k/kubelet-01-start 
Automatic merge from submit-queue (batch tested with PRs 58209, 57561, 58405). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

make the kubelet cobra command complete

This pull attempts a move from the cmd/kubelet to the cobra command where it can re-used.

/assign @mtaufen 
/assign @liggitt 
@ncdc fyi

xref: #34732

```release-note
NONE
```
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7f6dae7

@deads2k deads2k referenced this issue Jan 26, 2018

Merged

switch hyperkube to cobra #58408

@k8s-merge-robot k8s-merge-robot closed this in #58408 Jan 26, 2018

k8s-merge-robot added a commit that referenced this issue Jan 26, 2018

@k8s-merge-robot
Merge pull request #58408 from deads2k/hyperkube-01-fix 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

switch hyperkube to cobra

This makes use of cobra to layer the commands with a library that already supports composing commands.

Fixes #34732

```release-note
NONE
```
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6177b42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment