New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate kubenet bells and whistles to cni #38890

Open
freehan opened this Issue Dec 16, 2016 · 32 comments

Comments

@freehan
Member

freehan commented Dec 16, 2016

Stuff to migrate:

  1. sysctl bridge-nf-call-iptables
  2. promiscuous bridge mode and ebtables deduplication
  3. traffic shaper
  4. hostport
@cmluciano

This comment has been minimized.

Member

cmluciano commented Mar 8, 2017

@freehan Does that mean moving to https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/network/cni/cni.go ? I think I can accomplish 1) in tandem with #26005

@thockin

This comment has been minimized.

Member

thockin commented May 19, 2017

@dnardo probably a dup of other(s)

@dnardo

This comment has been minimized.

Contributor

dnardo commented May 19, 2017

Although I cannot assign myself to this, I'm currently working on this. #2 is pending merge in the CNI repo.

I have code ready for #1 and #3 (however we may need further discussion on #3 since it requires that the traffic shaper "knows" the pod IP on deletion, and right now we have no good way to do this in CNI)
#4 is being handled in another PR in the CNI repo.

I don't know of any dup issues, I'll take a look and I close any dups.

@cmluciano

This comment has been minimized.

Member

cmluciano commented May 19, 2017

/assign @dnardo

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented May 19, 2017

@cmluciano: GitHub didn't allow me to assign the following users: dnardo.

Note that only kubernetes members can be assigned.

In response to this:

/assign @dnardo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano

This comment has been minimized.

Member

cmluciano commented May 19, 2017

I'll assign this to myself tracking @dnardo. I think you send an email to the contrib-X SIG requesting member access to the kubernetes repo.

/assign

@dnardo

This comment has been minimized.

Contributor

dnardo commented May 19, 2017

/assign

@dnardo

This comment has been minimized.

Contributor

dnardo commented May 23, 2017

/assign @bowei

@dnardo

This comment has been minimized.

Contributor

dnardo commented May 23, 2017

/unassign @bowei

@thockin

This comment has been minimized.

Member

thockin commented Jun 9, 2017

This seems unlikely for 1.7?

@freehan freehan modified the milestones: next-candidate, v1.7 Jun 9, 2017

@freehan

This comment has been minimized.

Member

freehan commented Jun 9, 2017

Revendoring the CNI plugins is pending on a new CNI release.

Because CNI just went thru a separation between plugins and libcni, and there is no release tag in plugin repo.

@luxas

This comment has been minimized.

Member

luxas commented Jun 9, 2017

@freehan Will that upcoming new (splitted-up) release be called v0.6.0?

@freehan

This comment has been minimized.

Member

freehan commented Jun 9, 2017

@luxas I am not sure.
@dcbw comment?

@feiskyer

This comment has been minimized.

Member

feiskyer commented Aug 28, 2017

@freehan Seems there is still no clear plan of this? e.g. in which release kubenet will be deprecated?

@dnardo

This comment has been minimized.

Contributor

dnardo commented Aug 28, 2017

@feiskyer There is a plan, some work has been done already to do this. We will most likely target 1.9 for this since it's not super urgent to get in.

@luxas

This comment has been minimized.

Member

luxas commented Sep 1, 2017

We will most likely target 1.9 for this since it's not super urgent to get in.

Target what for v1.9? Deprecation? Removal? Feature parity?

@dnardo

This comment has been minimized.

Contributor

dnardo commented Sep 1, 2017

I've been targeting parity first. Or we could decide to not bring in the bridging related workarounds to the CNI bridge plugin. Some of these work-arounds are in already though.
Right now I'm waiting on containernetworking/plugins#42 to be merged and then the last part would be getting the "tc" part of kubenet in CNI and that should be it for parity.
The next step I think would be to deprecate and then eventually remove it altogether. I would think we would want some mileage on the code though before we completely remove it.

@luxas

This comment has been minimized.

Member

luxas commented Sep 1, 2017

@dnardo can you please write up a proposal document or google doc for this migration in order to make this roadmap transparent to the community?

@dnardo

This comment has been minimized.

Contributor

dnardo commented Sep 1, 2017

This was done sometime back and discussed on the sig-network, here is a link, it's a little out of date but the general idea is there:

https://docs.google.com/document/d/1q2TxBYROCf3um0FS0PGAZdznbZGS-h1aIJZQAs9xu-A/edit

@luxas

This comment has been minimized.

Member

luxas commented Sep 1, 2017

@dnardo that doc doesn't seem to be externally shared. Can you please share it with kubernetes-dev and/or the sig-network mailing lists?

@dnardo

This comment has been minimized.

Contributor

dnardo commented Sep 1, 2017

It's shared with kubernetes-sig-network@googlegroups.com are you joined to that group?

@luxas

This comment has been minimized.

Member

luxas commented Sep 1, 2017

yes. hah, strange, now works for me. not sure why it wouldn't let me in earlier...
Thanks, will look

@freehan freehan removed their assignment Oct 18, 2017

@squeed

This comment has been minimized.

Contributor

squeed commented Nov 16, 2017

Filed issue containernetworking/plugins#94 to implement a CNI traffic shaping plugin.

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Jan 16, 2018

/assign

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Mar 5, 2018

There is a proposal on Support traffic shaping for CNI network plugin, which is intended to fix "traffic shaper", please check it out.

Thanks!

@fejta-bot

This comment has been minimized.

fejta-bot commented Jun 3, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@bboreham

This comment has been minimized.

Contributor

bboreham commented Jun 4, 2018

/remove-lifecycle stale

@fejta-bot

This comment has been minimized.

fejta-bot commented Sep 2, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@thockin

This comment has been minimized.

Member

thockin commented Sep 2, 2018

@bowei

This comment has been minimized.

Member

bowei commented Sep 4, 2018

/assign @jingax10

@jellonek

This comment has been minimized.

Member

jellonek commented Nov 7, 2018

so what is the status of this issue?

@luxas

This comment has been minimized.

Member

luxas commented Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment