Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate kubenet bells and whistles to cni #38890

Closed
freehan opened this issue Dec 16, 2016 · 39 comments
Closed

Migrate kubenet bells and whistles to cni #38890

freehan opened this issue Dec 16, 2016 · 39 comments

Comments

@freehan
Copy link
Member

@freehan freehan commented Dec 16, 2016

Stuff to migrate:

  1. sysctl bridge-nf-call-iptables
  2. promiscuous bridge mode and ebtables deduplication
  3. traffic shaper
  4. hostport
@cmluciano
Copy link
Member

@cmluciano cmluciano commented Mar 8, 2017

@freehan Does that mean moving to https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/network/cni/cni.go ? I think I can accomplish 1) in tandem with #26005

@thockin
Copy link
Member

@thockin thockin commented May 19, 2017

@dnardo probably a dup of other(s)

@dnardo
Copy link
Contributor

@dnardo dnardo commented May 19, 2017

Although I cannot assign myself to this, I'm currently working on this. #2 is pending merge in the CNI repo.

I have code ready for #1 and #3 (however we may need further discussion on #3 since it requires that the traffic shaper "knows" the pod IP on deletion, and right now we have no good way to do this in CNI)
#4 is being handled in another PR in the CNI repo.

I don't know of any dup issues, I'll take a look and I close any dups.

@cmluciano
Copy link
Member

@cmluciano cmluciano commented May 19, 2017

/assign @dnardo

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented May 19, 2017

@cmluciano: GitHub didn't allow me to assign the following users: dnardo.

Note that only kubernetes members can be assigned.

In response to this:

/assign @dnardo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano
Copy link
Member

@cmluciano cmluciano commented May 19, 2017

I'll assign this to myself tracking @dnardo. I think you send an email to the contrib-X SIG requesting member access to the kubernetes repo.

/assign

@dnardo
Copy link
Contributor

@dnardo dnardo commented May 19, 2017

/assign

@dnardo
Copy link
Contributor

@dnardo dnardo commented May 23, 2017

/assign @bowei

@dnardo
Copy link
Contributor

@dnardo dnardo commented May 23, 2017

/unassign @bowei

@thockin
Copy link
Member

@thockin thockin commented Jun 9, 2017

This seems unlikely for 1.7?

@freehan freehan modified the milestones: next-candidate, v1.7 Jun 9, 2017
@freehan
Copy link
Member Author

@freehan freehan commented Jun 9, 2017

Revendoring the CNI plugins is pending on a new CNI release.

Because CNI just went thru a separation between plugins and libcni, and there is no release tag in plugin repo.

@luxas
Copy link
Member

@luxas luxas commented Jun 9, 2017

@freehan Will that upcoming new (splitted-up) release be called v0.6.0?

@freehan
Copy link
Member Author

@freehan freehan commented Jun 9, 2017

@luxas I am not sure.
@dcbw comment?

@feiskyer
Copy link
Member

@feiskyer feiskyer commented Aug 28, 2017

@freehan Seems there is still no clear plan of this? e.g. in which release kubenet will be deprecated?

@m1093782566
Copy link
Member

@m1093782566 m1093782566 commented Mar 5, 2018

There is a proposal on Support traffic shaping for CNI network plugin, which is intended to fix "traffic shaper", please check it out.

Thanks!

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Jun 3, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@bboreham
Copy link
Contributor

@bboreham bboreham commented Jun 4, 2018

/remove-lifecycle stale

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Sep 2, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@thockin
Copy link
Member

@thockin thockin commented Sep 2, 2018

@bowei
Copy link
Member

@bowei bowei commented Sep 4, 2018

/assign @jingax10

@jellonek
Copy link
Member

@jellonek jellonek commented Nov 7, 2018

so what is the status of this issue?

@cmluciano
Copy link
Member

@cmluciano cmluciano commented Jan 7, 2019

@caseydavenport @jingax10 @bowei I think we briefly discussed this at the Kubecon SIG Net meetup, but I do not recall what we determined were the missing features left.

@caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Jan 18, 2019

@cmluciano I think it's mostly just a packaging issue IIRC.

AFAIK we should be able to get feature parity with an external bridge/ptp/host-local CNI plugin configuration at this point.

@athenabot
Copy link

@athenabot athenabot commented May 6, 2019

@m1093782566 @dnardo @jingax10
If this issue has been triaged, please comment /remove-triage unresolved.

If you aren't able to handle this issue, consider unassigning yourself and/or adding the help-wanted label.

🤖 I am a bot run by vllry. 👩‍🔬

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Aug 14, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Sep 13, 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Oct 13, 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Oct 13, 2019

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet