Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DaemonsetController can't feel it when node recovered from outofdisk state #45628

Closed
lichuqiang opened this Issue May 11, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@lichuqiang
Copy link
Member

lichuqiang commented May 11, 2017

deamonset would not schedule pod on nodes of OutofDisk state,on the other hand, in it's updateNode func, it return directly if there is no change in labels or taints of the node.
That is, ds controller could not make sense when a node turn into OutofDisk state, or recover from it. Unless we restart the controller-manager component

@lichuqiang lichuqiang changed the title DaemonsetController can't make sense when node recovered from outofdisk state DaemonsetController can't feel it when node recovered from outofdisk state May 11, 2017

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented May 11, 2017

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented May 11, 2017

/assign @k82cn

@lichuqiang

This comment has been minimized.

Copy link
Member Author

lichuqiang commented May 11, 2017

@k82cn,what if other conditions in func "nodeShouldRunDaemonPod" changed? say, a node does not have enough cpu or memory resource to create the pod of ds, later I delete pods on it, and it satisfy the request now, but the ds controller could not feel it

@k82cn

This comment has been minimized.

Copy link
Member

k82cn commented May 11, 2017

@lichuqiang , thanks for your cases, they're reasonable to me; let me find solutions for them.

@kargakis kargakis added this to the v1.7 milestone May 21, 2017

k8s-github-robot pushed a commit that referenced this issue Jun 1, 2017

Kubernetes Submit Queue
Merge pull request #45649 from k82cn/k8s_45628
Automatic merge from submit-queue

Checked node condition for DaemonSets when updating node.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45628

**Release note**:

```release-note-none
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.