kubectl create service should accept --selector

[smarterclayton]

It should be possible to pass a selector to create services of type != ExternalName. The default selector isn't very useful.

[shiywang]

will take a look EDIT: @smarterclayton could you point me exact command you want here ? a little confuse how to use selector to create multiple services.

[xiangpengzhao]

I guess Clayton was saying kubectl create service.

[suyogbarve]

@shiywang are you fine if I take this up, I am half way with my solution for this.

[shiywang]

@suyogbarve go ahead, I will help to review : )

[suyogbarve]

@smarterclayton : since api.Service only support map[string]string or equality based labels (something=otherthing), new selector for "kubectl create svc " will be different from what we have present on parent command

Selector already present only for parent command -->
-l, --selector='': Selector (label query) to filter on, supports '=', '==', and '!='.

Proposed Selector for "kubectl create svc" --->
-l, --selector='': Selector to filter on, supports '='

Or am I missing something?

@shiywang thanks for helping

[suyogbarve]

@smarterclayton @shiywang PR #46546

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close