New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man pages do not build reproducibly #52269

Closed
bmwiedemann opened this Issue Sep 11, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@bmwiedemann
Contributor

bmwiedemann commented Sep 11, 2017

/kind bug

What happened:
When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in /usr/share/man/man1/kubectl.1 and other man pages.

-\fB--cloud-provider-gce-lb-src-cidrs\fP=209.85.152.0/22,209.85.204.0/22,130.211.0.0/22,35.191.0.0/16
+\fB--cloud-provider-gce-lb-src-cidrs\fP=35.191.0.0/16,209.85.152.0/22,209.85.204.0/22,130.211.0.0/22

coming from pkg/cloudprovider/providers/gce/gce_loadbalancer.go
that uses netsets.ParseIPNets([]string{"130.211.0.0/22", "35.191.0.0/16", "209.85.152.0/22", "209.85.204.0/22"}...)
and probably sets do not have any specific order, so it would need to be sorted on output.

What you expected to happen:
Every build should give identical results. See https://reproducible-builds.org/ for why this matters.

How to reproduce it (as minimally and precisely as possible):
See #48710

Anything else we need to know?:

Environment:

  • Kubernetes version: 1.7.0
  • OS (e.g. from /etc/os-release): openSUSE Tumbleweed
@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 11, 2017

Contributor

/sig release

Contributor

bmwiedemann commented Sep 11, 2017

/sig release

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Dec 10, 2017

Contributor

@ixdy somehow this bug seems to have been forgotten - can you help getting the right people to have a look?

Contributor

bmwiedemann commented Dec 10, 2017

@ixdy somehow this bug seems to have been forgotten - can you help getting the right people to have a look?

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Dec 11, 2017

Member

@bmwiedemann - can you please confirm that PR #57008 works for you?

Member

dims commented Dec 11, 2017

@bmwiedemann - can you please confirm that PR #57008 works for you?

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Dec 11, 2017

Contributor

I tested it and it looks good.

Contributor

bmwiedemann commented Dec 11, 2017

I tested it and it looks good.

@ixdy

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy Dec 11, 2017

Member

/assign @dims

I enjoy reading my highlights to find the issue has already been addressed. :)

Member

ixdy commented Dec 11, 2017

/assign @dims

I enjoy reading my highlights to find the issue has already been addressed. :)

@ixdy

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy Dec 11, 2017

Member

@bmwiedemann Sorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)

Member

ixdy commented Dec 11, 2017

@bmwiedemann Sorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)

@ixdy

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy Dec 11, 2017

Member

/area build-release

Member

ixdy commented Dec 11, 2017

/area build-release

k8s-merge-robot added a commit that referenced this issue Dec 16, 2017

Merge pull request #57008 from dims/sort-cidrs-for-reproducible-build
Automatic merge from submit-queue (batch tested with PRs 56997, 57008, 56984, 56975, 56955). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Sort default cidrs for reproducible builds

**What this PR does / why we need it**:

In different distros or environments, we may end up with a different
order of the default string printed during help and man page generation,
So we should sort so the string we print is the same everytime.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #52269

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Sep 23, 2018

Member

related to kubernetes/release#637

/reopen

Member

dims commented Sep 23, 2018

related to kubernetes/release#637

/reopen

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 23, 2018

Contributor

@dims: Reopening this issue.

In response to this:

related to kubernetes/release#637

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Sep 23, 2018

@dims: Reopening this issue.

In response to this:

related to kubernetes/release#637

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment