New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate the kubeletconfig API to beta #53084

Closed
mtaufen opened this Issue Sep 26, 2017 · 11 comments

Comments

@mtaufen
Contributor

mtaufen commented Sep 26, 2017

Goal is to hit beta in 1.10, wrt kubernetes/enhancements#281

@mtaufen mtaufen added this to the v1.9 milestone Sep 26, 2017

@mtaufen mtaufen self-assigned this Sep 26, 2017

@k8s-merge-robot k8s-merge-robot removed this from the v1.9 milestone Oct 9, 2017

k8s-merge-robot added a commit that referenced this issue Oct 11, 2017

Merge pull request #53088 from mtaufen/remove-experimental-deprecated…
…-kubeletconfig

Automatic merge from submit-queue (batch tested with PRs 53204, 53364, 53559, 53589, 53088). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Mulligan: Remove deprecated and experimental fields from KubeletConfiguration

Revert "Merge pull request #51857 from kubernetes/revert-51307-kc-type-refactor"

This reverts commit 9d27d92, reversing
changes made to 2e69d4e.

See original: #51307

We punted this from 1.8 so it could go through an API review. The point
of this PR is that we are trying to stabilize the kubeletconfig API so
that we can move it out of alpha, and unblock features like Dynamic
Kubelet Config, Kubelet loading its initial config from a file instead
of flags, kubeadm and other install tools having a versioned API to rely
on, etc.

We shouldn't rev the version without both removing all the deprecated
junk from the KubeletConfiguration struct, and without (at least
temporarily) removing all of the fields that have "Experimental" in
their names. It wouldn't make sense to lock in to deprecated fields.
"Experimental" fields can be audited on a 1-by-1 basis after this PR,
and if found to be stable (or sufficiently alpha-gated), can be restored
to the KubeletConfiguration without the "Experimental" prefix.

Related issue: #53084

**Release note**:
```release-note
NONE
```

/cc @kubernetes/api-reviewers

@luxas luxas added this to the v1.9 milestone Oct 12, 2017

@luxas luxas removed the kind/bug label Oct 13, 2017

@dims

This comment has been minimized.

Member

dims commented Nov 15, 2017

@mtaufen what else is needed for 1.9? (or can we move this to 1.10)?

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Nov 16, 2017

There's a checklist in this PR: #53833

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Nov 16, 2017

We're very close

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Nov 22, 2017

[MILESTONENOTIFIER] Milestone Removed From Issue

@mtaufen @kubernetes/sig-cluster-lifecycle-misc @kubernetes/sig-node-misc

Important: Code freeze is in effect and only issues with priority/critical-urgent may remain in the v1.9 milestone.

Help

@k8s-merge-robot k8s-merge-robot removed this from the v1.9 milestone Nov 22, 2017

@luxas luxas added this to the v1.10 milestone Dec 22, 2017

@luxas

This comment has been minimized.

Member

luxas commented Dec 22, 2017

@mtaufen repurposed for v1.10

@luxas luxas changed the title from Rev the kubeletconfig API out of alpha to Graduate the kubeletconfig API to beta Dec 22, 2017

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Dec 24, 2017

@jberkus

This comment has been minimized.

jberkus commented Feb 21, 2018

is this on track for 1.10? I don't show any activity in this issue since December.

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Feb 21, 2018

This can be closed, it's done.

@timothysc

This comment has been minimized.

Member

timothysc commented Feb 21, 2018

@kubernetes/sig-cluster-lifecycle-misc (we should move to enable asap).

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Feb 26, 2018

@mtaufen @timothysc does it mean that we should enable Dynamic Kubelet Configuration by default in kubeadm after this graduation?

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Feb 26, 2018

No, this is for the kubelet's config file API (and, equivalently, the serialized payload you send in a ConfigMap when using dynamic config). The surrounding machinery that delivers the payload for dynamic config is still considered alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment