New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAR approver generates too much debug output when bootstrapping #53734

Closed
smarterclayton opened this Issue Oct 11, 2017 · 1 comment

Comments

Projects
None yet
6 participants
@smarterclayton
Contributor

smarterclayton commented Oct 11, 2017

Each node waiting for bootstrapping creates 1 line per 2-3s in the logs when the requesting client doesn't have access. It should not be logging at v(0), these are all v(4) level. We should be reporting these appropriately. I don't want a 5k node cluster showing this.

E1011 12:22:21.620025   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:21.626418   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:21.638339   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:21.659881   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:21.701474   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:21.782825   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:21.944014   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:22.268229   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:22.910677   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:24.192404   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved
E1011 12:22:26.753727   21797 certificate_controller.go:140] Sync node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ failed with : recognized csr "node-csr-6PT9Ijw0Pum-dxRUASxn504jwwaVt4Bj7heLY7aGQMQ" as [nodeclient] but subject access review was not approved

@kubernetes/sig-cluster-lifecycle-bugs

@hzxuzhonghu

This comment has been minimized.

Show comment
Hide comment
@hzxuzhonghu

hzxuzhonghu Oct 12, 2017

Member

I'd like to fix it

Member

hzxuzhonghu commented Oct 12, 2017

I'd like to fix it

k8s-merge-robot added a commit that referenced this issue Nov 21, 2017

Merge pull request #53907 from mikedanese/base-delay
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

sarapprover: increase base delay of per item rate limit

from 5 miliseconds to 1 second

fixes #53734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment