New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e storage tests "Pod Disks" and "PD" don't wait for detach in AWS #53745

Closed
jeffvance opened this Issue Oct 11, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@jeffvance
Contributor

jeffvance commented Oct 11, 2017

The GCE "PD" tests (test/e2e/storage/volumes.go) and the "Pod Disks" tests (test/e2e/storage/pd.go) call detachAndDeletePDs which calls detachPD. detachPD handles both GCE/GKE and AWS/EC2 providers as desired. However, detachAndDeletePDs also calls waitForPDDetach and this func does not support AWS. So there is no wait for detach in AWS test environments. IMO, the detach support and the wait-for-detach support should be symmetric.

/kind bug
Note: this might not be a bug but it looks odd to me...

@jeffvance

This comment has been minimized.

Show comment
Hide comment
@jeffvance

jeffvance Oct 11, 2017

Contributor

/sig storage

Contributor

jeffvance commented Oct 11, 2017

/sig storage

@jeffvance jeffvance changed the title from e2e test "Pod Disks" and "PD" don't wait for detach in AWS env to e2e tests "Pod Disks" and "PD" don't wait for detach in AWS env Oct 11, 2017

@jeffvance jeffvance changed the title from e2e tests "Pod Disks" and "PD" don't wait for detach in AWS env to e2e storage tests "Pod Disks" and "PD" don't wait for detach in AWS env Oct 11, 2017

@jeffvance jeffvance changed the title from e2e storage tests "Pod Disks" and "PD" don't wait for detach in AWS env to e2e storage tests "Pod Disks" and "PD" don't wait for detach in AWS Oct 11, 2017

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Jan 11, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

fejta-bot commented Jan 11, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Feb 11, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

fejta-bot commented Feb 11, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Mar 13, 2018

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot commented Mar 13, 2018

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment