New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need validate `EnforceNodeAllocatable` values in kubeletconfig api validation test. #55664

Closed
miaoyq opened this Issue Nov 14, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@miaoyq
Member

miaoyq commented Nov 14, 2017

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
In kubeletconfig api validation test, it is incomplete about EnforceNodeAllocatable, see:

EnforceNodeAllocatable: []string{"pods"},

and
EnforceNodeAllocatable: []string{"pods"},

What you expected to happen:
Need validate all possible values for EnforceNodeAllocatable.
How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@miaoyq

This comment has been minimized.

Show comment
Hide comment
@miaoyq

miaoyq Nov 14, 2017

Member

/sig node

Member

miaoyq commented Nov 14, 2017

/sig node

k8s-merge-robot added a commit that referenced this issue Nov 15, 2017

Merge pull request #55389 from miaoyq/completet-test-case
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Complete test case for kubeletconfig api validation

**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #55664

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment