New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/log-dump/log-dump.sh: line 235: NODE_NAMES[@]: unbound variable #55675

Closed
porridge opened this Issue Nov 14, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@porridge
Member

porridge commented Nov 14, 2017

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

What happened:
In https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/55056/pull-kubernetes-kubemark-e2e-gce/62590/ e2e-up.sh failed due to #55229.
Afterwards log-dump.sh crashed as follows:

W1114 08:13:34.011] 2017/11/14 08:13:34 util.go:155: Running: ./cluster/log-dump/log-dump.sh /workspace/_artifacts
W1114 08:13:34.059] Trying to find master named 'e2e-62590-master'
W1114 08:13:34.059] Looking for address 'e2e-62590-master-ip'
I1114 08:13:34.160] Checking for custom logdump instances, if any
I1114 08:13:34.160] Sourcing kube-util.sh
I1114 08:13:34.160] Detecting project
I1114 08:13:34.161] Project: k8s-jkns-pr-kubemark
I1114 08:13:34.161] Network Project: k8s-jkns-pr-kubemark
I1114 08:13:34.161] Zone: us-central1-f
I1114 08:13:34.161] Dumping logs from master locally to '/workspace/_artifacts'
W1114 08:13:34.805] Using master: e2e-62590-master (external IP: 104.198.218.200)
I1114 08:14:04.313] Changing logfiles to be world-readable for download
W1114 08:14:04.970] ERROR: (gcloud.compute.ssh) Could not fetch resource:
W1114 08:14:04.971]  - The resource 'projects/k8s-jkns-pr-kubemark/zones/us-central1-f/instances/e2e-62590-master' was not found
W1114 08:14:04.971] 
W1114 08:14:10.675] ERROR: (gcloud.compute.ssh) Could not fetch resource:
W1114 08:14:10.675]  - The resource 'projects/k8s-jkns-pr-kubemark/zones/us-central1-f/instances/e2e-62590-master' was not found
W1114 08:14:10.675] 
W1114 08:14:16.400] ERROR: (gcloud.compute.ssh) Could not fetch resource:
W1114 08:14:16.401]  - The resource 'projects/k8s-jkns-pr-kubemark/zones/us-central1-f/instances/e2e-62590-master' was not found
W1114 08:14:16.401] 
W1114 08:14:22.149] ERROR: (gcloud.compute.ssh) Could not fetch resource:
W1114 08:14:22.149]  - The resource 'projects/k8s-jkns-pr-kubemark/zones/us-central1-f/instances/e2e-62590-master' was not found
W1114 08:14:22.149] 
W1114 08:14:27.891] ERROR: (gcloud.compute.ssh) Could not fetch resource:
W1114 08:14:27.892]  - The resource 'projects/k8s-jkns-pr-kubemark/zones/us-central1-f/instances/e2e-62590-master' was not found
W1114 08:14:27.892] 
W1114 08:14:33.665] ERROR: (gcloud.compute.ssh) Could not fetch resource:
W1114 08:14:33.666]  - The resource 'projects/k8s-jkns-pr-kubemark/zones/us-central1-f/instances/e2e-62590-master' was not found
W1114 08:14:33.666] 
I1114 08:14:33.766] Copying 'kern kube-apiserver kube-apiserver-audit kube-scheduler rescheduler kube-controller-manager etcd etcd-events glbc cluster-autoscaler kube-addon-manager fluentd startupscript docker kubelet supervisor/supervisord supervisor/kubelet-stdout supervisor/kubelet-stderr supervisor/docker-stdout supervisor/docker-stderr' from e2e-62590-master
W1114 08:14:34.464] ERROR: (gcloud.compute.instances.get-serial-port-output) Could not fetch serial port output: The resource 'projects/k8s-jkns-pr-kubemark/zones/us-central1-f/instances/e2e-62590-master' was not found
W1114 08:14:35.198] ERROR: (gcloud.compute.scp) Could not fetch resource:
W1114 08:14:35.198]  - The resource 'projects/k8s-jkns-pr-kubemark/zones/us-central1-f/instances/e2e-62590-master' was not found
W1114 08:14:35.199] 
I1114 08:14:35.299] Dumping logs from nodes locally to '/workspace/_artifacts'
I1114 08:14:35.299] Detecting nodes in the cluster
W1114 08:14:36.462] ./cluster/log-dump/log-dump.sh: line 235: NODE_NAMES[@]: unbound variable
W1114 08:14:36.462] 2017/11/14 08:14:36 util.go:157: Step './cluster/log-dump/log-dump.sh /workspace/_artifacts' finished in 1m2.451062927s

What you expected to happen:

Graceful exit.

@porridge

This comment has been minimized.

Show comment
Hide comment
@porridge

porridge Nov 14, 2017

Member

@kubernetes/sig-testing-bugs

Member

porridge commented Nov 14, 2017

@kubernetes/sig-testing-bugs

@ixdy

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy Nov 15, 2017

Member

/assign @porridge

Member

ixdy commented Nov 15, 2017

/assign @porridge

k8s-merge-robot added a commit that referenced this issue Nov 16, 2017

Merge pull request #55682 from porridge/unset-array
Automatic merge from submit-queue (batch tested with PRs 55682, 55444, 55456, 55717, 55131). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Do not crash on empty NODE_NAMES array.

**Which issue(s) this PR fixes**:
Fixes #55675

**Release note**:
```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment