New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI: container runtime interface support PodSandboxImage config #55676

Closed
goby opened this Issue Nov 14, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@goby

goby commented Nov 14, 2017

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature

What happened:
When use remote container runtime, the remote can't get any PodSandboxImage config set by kubelet --pod-infra-container-image

What you expected to happen:
We want the all container runtime should know what's right PodSandboxImage

How to reproduce it (as minimally and precisely as possible):

  1. Add in new node with frakti into k8s cluster
  2. The kubelet with --pod-infra-container-image=goby/pause-amd64:3.0 --container-runtime=remote --container-runtime-endpoint=/var/run/frakti.sock options
  3. I expect frakti can create sandbox container with goby/pause-amd64:3.0, but get default gcr.io/google_containers/pause-amd64:3.0(k8s version: v1.8.2)

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.2", GitCommit:"bdaeafa71f6c7c04636251031f93464384d54963", GitTreeState:"clean", BuildDate:"2017-10-24T19:48:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.2", GitCommit:"bdaeafa71f6c7c04636251031f93464384d54963", GitTreeState:"clean", BuildDate:"2017-10-24T19:38:10Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
  • Cloud provider or hardware configuration: bootstrap by kubeadm v1.8.2
  • OS (e.g. from /etc/os-release): Debian GNU/Linux 9 (stretch)
  • Kernel (e.g. uname -a): SMP Debian 4.9.30-2+deb9u2 (2017-06-26) x86_64 GNU/Linux
  • Install tools: kubeadm
  • Others:
@goby

This comment has been minimized.

Show comment
Hide comment
@goby

goby Nov 14, 2017

/sig node

goby commented Nov 14, 2017

/sig node

@goby

This comment has been minimized.

Show comment
Hide comment
@goby

goby Nov 15, 2017

@dixudx good news! thanks!

goby commented Nov 15, 2017

@dixudx good news! thanks!

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Feb 13, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot commented Feb 13, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@goby

This comment has been minimized.

Show comment
Hide comment
@goby

goby Feb 23, 2018

/remove-lifecycle stale

goby commented Feb 23, 2018

/remove-lifecycle stale

@dixudx

This comment has been minimized.

Show comment
Hide comment
@dixudx

dixudx Mar 7, 2018

Member

@goby Actually we do a no-op when the container runtime is remote.

case kubetypes.RemoteContainerRuntime:
// No-op.
break

This is why PodSandboxImage config can not be set by flag --pod-infra-container-image for remote.

In your case, the correct place to change the default sandbox image is in frakti.

Member

dixudx commented Mar 7, 2018

@goby Actually we do a no-op when the container runtime is remote.

case kubetypes.RemoteContainerRuntime:
// No-op.
break

This is why PodSandboxImage config can not be set by flag --pod-infra-container-image for remote.

In your case, the correct place to change the default sandbox image is in frakti.

satyasm pushed a commit to satyasm/kubernetes that referenced this issue Apr 25, 2018

Merge pull request kubernetes#62982 from dixudx/warning_kubelet_remot…
…e_sandbox

Automatic merge from submit-queue (batch tested with PRs 62982, 63075, 63067, 62877, 63141). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

add warnings on using pod-infra-container-image for remote container runtime

**What this PR does / why we need it**:
We should warn on using `--pod-infra-container-image` to avoid confusions, when users are using remote container runtime.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes#55676,kubernetes#62388,kubernetes#62732

**Special notes for your reviewer**:
/cc @kubernetes/sig-node-pr-reviews 

**Release note**:

```release-note
add warnings on using pod-infra-container-image for remote container runtime
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment