New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods with GPU requests should be rejected early if Accelerators feature gate is off #55679

Closed
tengqm opened this Issue Nov 14, 2017 · 4 comments

Comments

Projects
None yet
6 participants
@tengqm
Contributor

tengqm commented Nov 14, 2017

/kind bug

What happened*:
When requesting a Pod creation with alpha.kubernetes.io/nvidia-gpu specified, I was hoping that the creation is a failure because I didn't enable the Accelerators feature gate. However, it succeeded. The pod is stuck in Pending status which is fine.

What you expected to happen:
I'm expecting that a Pod requesting GPU will be rejected when its container resource requirements are validated. Having the GPU usage guarded by the feature gate will help cleaning removing it in future when device plugin stabilizes.

How to reproduce it (as minimally and precisely as possible):
Disable Accelerators feature gate and create a Pod with GPU request or limit, the pod is successfully created. It means that the feature gate is not doing its job.

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Nov 15, 2017

Member

/sig node

Member

dims commented Nov 15, 2017

/sig node

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Feb 13, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot commented Feb 13, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Mar 15, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

fejta-bot commented Mar 15, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@mindprince

This comment has been minimized.

Show comment
Hide comment
@mindprince

mindprince Mar 23, 2018

Member

/close

This is deprecated in 1.10 and going to be removed in 1.11: #61498

Member

mindprince commented Mar 23, 2018

/close

This is deprecated in 1.10 and going to be removed in 1.11: #61498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment